emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]
@ 2022-03-29 13:09 Ignacio Casso
  2022-03-30  7:13 ` Ignacio Casso
  2022-03-31 12:38 ` [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)] Max Nikulin
  0 siblings, 2 replies; 12+ messages in thread
From: Ignacio Casso @ 2022-03-29 13:09 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

After last Saturday's hour change in Spain, org-agenda thinks that
timestamps after 23:00 correspond to the next day in Emacs 29. I'm not
actually sure if that is the reason, since I usually use Emacs 27, but I
guess it must be that if I have found out three days after the hour
change.

I have tried to track down the problem, and it doesn't seem to be the
fault of any org-mode code change. The problem is that
(org-time-string-to-time timestamp), defined as (encode-time
(org-parse-time-string timestamp)), returns different things in Emacs 27
and Emacs 29.

Let's consider the timestamp "<2022-03-29 mar 23:00>" as an example:

1) (org-parse-time-string "<2022-03-29 mar 23:00>") returns (0 0 23 29 3
2022 nil nil nil).

2) (encode-time '(0 0 23 29 3 2022 nil nil nil)) returns '(25155 29520)
in Emacs 27, but (25155 33120) in Emacs 29

3.1) (time-to-days '(25155 29520)) returns 738243

3.2) (time-to-days '(25155 33120)) returns 738244

4) (org-today) returns 738243

Therefore, org-agenda thinks that "<2022-03-29 mar 23:00>" is today in
Emacs 27, but tomorrow in Emacs 29.

`encode-time' is defined in C, and is probably system dependent, so this
is probably not an org-mode bug. But maybe org-mode code could try to be
smart about this? I don't know if it's even possible.

And if this should not be fixed in org-mode, do you know were it should?
It could be an Emacs bug? Or maybe the problem is in my system?

Regards,

--Ignacio


Emacs  : GNU Emacs 29.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0)
 of 2022-03-29
Package: Org mode version 9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-04-23  8:24 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29 13:09 [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)] Ignacio Casso
2022-03-30  7:13 ` Ignacio Casso
2022-03-30  9:48   ` [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day Max Nikulin
2022-03-30 10:17     ` Ignacio Casso
2022-03-31 12:38 ` [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)] Max Nikulin
2022-03-31 14:11   ` Ignacio Casso
2022-03-31 16:57     ` Max Nikulin
2022-03-31 21:37       ` Tim Cross
2022-04-05  4:20       ` Kyle Meyer
2022-04-22 15:47         ` Max Nikulin
2022-04-23  7:20           ` Ignacio Casso
2022-04-23  8:23             ` Max Nikulin

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).