From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Frankel Subject: Re: [Patch] Few small fixes to html header Date: Fri, 28 Mar 2014 10:43:56 -0400 Message-ID: <20701b6c1cc0f8eda606e30a052e8e68@mail.rickster.com> References: <87vbuz1kky.fsf@neutrico-themes.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTY0n-0000C6-Bs for emacs-orgmode@gnu.org; Fri, 28 Mar 2014 10:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTY0i-0003Iz-IP for emacs-orgmode@gnu.org; Fri, 28 Mar 2014 10:44:01 -0400 Received: from mail.rickster.com ([204.62.15.78]:33421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTY0i-0003Io-EK for emacs-orgmode@gnu.org; Fri, 28 Mar 2014 10:43:56 -0400 In-Reply-To: <87vbuz1kky.fsf@neutrico-themes.pl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Marcin Antczak Cc: emacs-orgmode@gnu.org On 2014-03-27 15:57, Marcin Antczak wrote: > I've attached patch below, but I'm affraid that there is something=20 > wrong > with indentation. > I'm not sure if there is problem with my settings or just entire > ox-html.el is indented badly. Unfortunately, ox-html is indented with a combination of tabs and spaces, you can turn on whitespace-mode to see. I'm not sure why your saving the file has touched areas you didn't edit. Did you do a re-indent or have a whitespace-cleanup or convert-tabs-to-spaces hook turned on? >=20 > My patch fixes HTML meta data produced on export by ox-html.el >=20 > 1. Meta charset definition should be set before title as document > title can contain > some unicode symbols etc. I believe this is the gist of your patch (bug fix?) -- putting the content-type declaration before the title (it's hard to tell due to all the changes in your patch)? If so, i don't see the need. Following is a sample org file w/ a unicode character in the title. It renders correctly on both internet explorer 9 and chrome 31.0.1650.63, the only browsers i have available right now. I believe that the meta content is parsed before the rendering, so the position within the header is irrelevant. #+BEGIN_SRC org ,#+TITLE: =E2=98=91 \gamma ,#+OPTIONS: toc:nil ,* Test utf-8 title Put =E2=98=91 \gamma (checkbox and gamma) unicode characters in the titl= e. #+END_SRC > 2. Added viewport declaration as described here: >=20 > https://github.com/h5bp/html5-boilerplate/blob/v4.3.0/doc/html.md >=20 > here: >=20 > https://developer.apple.com/library/safari/documentation/AppleApplicati= ons/Reference/SafariWebContent/UsingtheViewport/UsingtheViewport.html I don't believe it's appropriate to have as a default in ox-html as the current exporter makes no attempt at "responsive design". If you would like your exported documents to include it, you can use the HTML_HEAD_EXTRA property on a per-file basis, or customize the variable `org-html-head-extra'. > 3. Fixed unnecessary "\n" at the end of Description meta. > 4. Removed unnecessary spaces in meta tags. Are these bugs or simply stylistic cleanup? rick