* [PATCH] tags search: faster tags matcher by trusting scanner tags @ 2012-03-15 23:16 Ilya Shlyakhter 2012-03-16 3:13 ` Nick Dokos 0 siblings, 1 reply; 11+ messages in thread From: Ilya Shlyakhter @ 2012-03-15 23:16 UTC (permalink / raw) To: emacs-orgmode [-- Attachment #1.1: Type: text/plain, Size: 468 bytes --] The attached patch speeds up tags matching ( 50s --> 5s for my most common search ), by turning on org-trust-scanner-tags within the matcher. (When it's off, getting a non-inherited property's value causes a call to org-entry-properties to fetch all properties into a cache, including ALLTAGS; fetching ALLTAGS involves calling (org-get-tags-at), which is slow when org-trust-scanner-tags is off.) Can this cause problems / was this off for a reason? thanks, ilya [-- Attachment #1.2: Type: text/html, Size: 525 bytes --] [-- Attachment #2: 0022-Tags-matcher-turned-on-org-trust-scanner-tags-within.patch --] [-- Type: application/octet-stream, Size: 1068 bytes --] From 40ef4f9ba67a6b0466ca067d29f07c9a625929b4 Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter <ilya_shl@alum.mit.edu> Date: Thu, 15 Mar 2012 19:05:06 -0400 Subject: [PATCH 22/22] Tags matcher: turned on org-trust-scanner-tags within the matcher. * lisp/org.el (org-make-tags-matcher): Bind org-trust-scanner-tags to t around the matcher, so that getting the ALLTAGS property does not take so long. TINYCHANGE --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index ad63213..61f8716 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -13133,7 +13133,7 @@ instead of the agenda files." (setq tagsmatcher nil)) (setq tagsmatcher (if (> (length orlist) 1) (cons 'or orlist) (car orlist))) (setq tagsmatcher - (list 'progn '(setq org-cached-props nil) tagsmatcher))) + (list 'let '((org-trust-scanner-tags t)) '(setq org-cached-props nil) tagsmatcher))) ;; Make the todo matcher (if (or (not todomatch) (not (string-match "\\S-" todomatch))) (setq todomatcher t) -- 1.7.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-15 23:16 [PATCH] tags search: faster tags matcher by trusting scanner tags Ilya Shlyakhter @ 2012-03-16 3:13 ` Nick Dokos 2012-03-16 4:31 ` Ilya Shlyakhter 0 siblings, 1 reply; 11+ messages in thread From: Nick Dokos @ 2012-03-16 3:13 UTC (permalink / raw) To: Ilya Shlyakhter; +Cc: nicholas.dokos, emacs-orgmode Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote: > The attached patch speeds up tags matching ( 50s --> 5s for my most > common search ), by turning on org-trust-scanner-tags within the > matcher. > > (When it's off, getting a non-inherited property's value causes a call > to org-entry-properties to fetch all properties into a cache, > including ALLTAGS; fetching ALLTAGS involves calling > (org-get-tags-at), which is slow when org-trust-scanner-tags is off.) > > Can this cause problems / was this off for a reason? > I haven't looked at your patch carefully enough to know if it will or will not cause problems, but check the doc for org-map-entries: it has some guidelines about where the technique can be used and where it cannot: ,---- | If your function needs to retrieve the tags including inherited tags | at the *current* entry, you can use the value of the variable | `org-scanner-tags' which will be much faster than getting the value | with `org-get-tags-at'. If your function gets properties with | `org-entry-properties' at the *current* entry, bind `org-trust-scanner-tags' | to t around the call to `org-entry-properties' to get the same speedup. | Note that if your function moves around to retrieve tags and properties at | a *different* entry, you cannot use these techniques. `---- There are warnings that this variable is for internal dynamical scoping only, so I suspect you should not mess with the default. If your search can make the needed guarantees, then you can just wrap it in a let to get the speedup. Otherwise, it probably should be left alone. Nick ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 3:13 ` Nick Dokos @ 2012-03-16 4:31 ` Ilya Shlyakhter 2012-03-16 4:34 ` Ilya Shlyakhter 2012-03-16 6:10 ` Nick Dokos 0 siblings, 2 replies; 11+ messages in thread From: Ilya Shlyakhter @ 2012-03-16 4:31 UTC (permalink / raw) To: emacs-orgmode; +Cc: nicholas.dokos [-- Attachment #1.1: Type: text/plain, Size: 2573 bytes --] ,---- | If your function needs to retrieve the tags including inherited tags | at the *current* entry, 'Function' here refers to the FUNC parameter of org-map-entries, not the MATCHER parameter. The matcher is constructed by org-make-tags-matcher, so we know everything it does -- it does not move around and only asks about the current entry's tags and properties. org-scan-tags only invokes the matcher at the current entry, and sets org-scanner-tags correctly for that call. But, you're right that there is a problem: while org-scan-tags sets org-scanner-tags correctly before (eval matcher), other users of the matcher -- e.g. org-clock-get-table-data -- might not. So, org-trust-scanner-tags should be set not in the matcher, but in the function that calls the matcher. A corrected patch is attached. thanks, ilya On Thu, Mar 15, 2012 at 11:13 PM, Nick Dokos <nicholas.dokos@hp.com> wrote: > Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote: > > > The attached patch speeds up tags matching ( 50s --> 5s for my most > > common search ), by turning on org-trust-scanner-tags within the > > matcher. > > > > (When it's off, getting a non-inherited property's value causes a call > > to org-entry-properties to fetch all properties into a cache, > > including ALLTAGS; fetching ALLTAGS involves calling > > (org-get-tags-at), which is slow when org-trust-scanner-tags is off.) > > > > Can this cause problems / was this off for a reason? > > > > I haven't looked at your patch carefully enough to know if it will or > will not cause problems, but check the doc for org-map-entries: it has > some guidelines about where the technique can be used and where it > cannot: > > ,---- > | If your function needs to retrieve the tags including inherited tags > | at the *current* entry, you can use the value of the variable > | `org-scanner-tags' which will be much faster than getting the value > | with `org-get-tags-at'. If your function gets properties with > | `org-entry-properties' at the *current* entry, bind > `org-trust-scanner-tags' > | to t around the call to `org-entry-properties' to get the same speedup. > | Note that if your function moves around to retrieve tags and properties > at > | a *different* entry, you cannot use these techniques. > `---- > > > There are warnings that this variable is for internal dynamical scoping > only, > so I suspect you should not mess with the default. If your search can make > the needed guarantees, then you can just wrap it in a let to get the > speedup. > Otherwise, it probably should be left alone. > > Nick > > [-- Attachment #1.2: Type: text/html, Size: 3217 bytes --] [-- Attachment #2: 0002-Tags-properties-matcher-faster-matching-by-trusting-.patch --] [-- Type: application/octet-stream, Size: 1043 bytes --] From 95c38b06803aec0787bc2eaab3d0062221390292 Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter <ilya_shl@alum.mit.edu> Date: Fri, 16 Mar 2012 00:10:25 -0400 Subject: [PATCH 2/2] Tags/properties matcher: faster matching by trusting org-scanner-tags * lisp/org.el (org-scan-tags): Bind org-trust-scanner-tags to t while evaluating the matcher, since the matcher is always evaluated at the current entry. TINYCHANGE --- lisp/org.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index ad63213..951f692 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12906,7 +12906,8 @@ headlines matching this string." ;; eval matcher only when the todo condition is OK (and (or (not todo-only) (member todo org-not-done-keywords)) - (let ((case-fold-search t)) (eval matcher))) + (let ((case-fold-search t) (org-trust-scanner-tags t)) + (eval matcher))) ;; Call the skipper, but return t if it does not skip, ;; so that the `and' form continues evaluating -- 1.7.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 4:31 ` Ilya Shlyakhter @ 2012-03-16 4:34 ` Ilya Shlyakhter 2012-03-16 10:35 ` Carsten Dominik 2012-03-16 6:10 ` Nick Dokos 1 sibling, 1 reply; 11+ messages in thread From: Ilya Shlyakhter @ 2012-03-16 4:34 UTC (permalink / raw) To: emacs-orgmode; +Cc: nicholas.dokos [-- Attachment #1.1: Type: text/plain, Size: 2823 bytes --] Here is a similar patch for org-clock's use of tags/properties matcher. On Fri, Mar 16, 2012 at 12:31 AM, Ilya Shlyakhter <ilya_shl@alum.mit.edu>wrote: > ,---- > | If your function needs to retrieve the tags including inherited tags > | at the *current* entry, > > 'Function' here refers to the FUNC parameter of org-map-entries, not the > MATCHER parameter. > The matcher is constructed by org-make-tags-matcher, so we know everything > it does -- > it does not move around and only asks about the current entry's tags and > properties. > org-scan-tags only invokes the matcher at the current entry, and sets > org-scanner-tags > correctly for that call. > > But, you're right that there is a problem: while org-scan-tags sets > org-scanner-tags correctly > before (eval matcher), other users of the matcher -- e.g. > org-clock-get-table-data -- might not. > So, org-trust-scanner-tags should be set not in the matcher, but in the > function that calls > the matcher. A corrected patch is attached. > > thanks, > > ilya > > > On Thu, Mar 15, 2012 at 11:13 PM, Nick Dokos <nicholas.dokos@hp.com>wrote: > >> Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote: >> >> > The attached patch speeds up tags matching ( 50s --> 5s for my most >> > common search ), by turning on org-trust-scanner-tags within the >> > matcher. >> > >> > (When it's off, getting a non-inherited property's value causes a call >> > to org-entry-properties to fetch all properties into a cache, >> > including ALLTAGS; fetching ALLTAGS involves calling >> > (org-get-tags-at), which is slow when org-trust-scanner-tags is off.) >> > >> > Can this cause problems / was this off for a reason? >> > >> >> I haven't looked at your patch carefully enough to know if it will or >> will not cause problems, but check the doc for org-map-entries: it has >> some guidelines about where the technique can be used and where it >> cannot: >> >> ,---- >> | If your function needs to retrieve the tags including inherited tags >> | at the *current* entry, you can use the value of the variable >> | `org-scanner-tags' which will be much faster than getting the value >> | with `org-get-tags-at'. If your function gets properties with >> | `org-entry-properties' at the *current* entry, bind >> `org-trust-scanner-tags' >> | to t around the call to `org-entry-properties' to get the same speedup. >> | Note that if your function moves around to retrieve tags and properties >> at >> | a *different* entry, you cannot use these techniques. >> `---- >> >> >> There are warnings that this variable is for internal dynamical scoping >> only, >> so I suspect you should not mess with the default. If your search can make >> the needed guarantees, then you can just wrap it in a let to get the >> speedup. >> Otherwise, it probably should be left alone. >> >> Nick >> >> > [-- Attachment #1.2: Type: text/html, Size: 3688 bytes --] [-- Attachment #2: 0003-Clocking-work-time-faster-filtering-of-clock-entries.patch --] [-- Type: application/octet-stream, Size: 1108 bytes --] From 4f7f91ae62d425f7a89738b28006b1743a6bea4d Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter <ilya_shl@alum.mit.edu> Date: Fri, 16 Mar 2012 00:25:18 -0400 Subject: [PATCH 3/3] Clocking work time: faster filtering of clock entries by trusting org-scanner-tags * lisp/org-clock.el (org-clock-get-table-data): Bind org-scanner-tags to tags-list and org-trust-scanner-tags to t while evaluating the matcher, since the matcher is always evaluated at the current entry. TINYCHANGE --- lisp/org-clock.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 9206608..46d9af8 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -2463,7 +2463,9 @@ TIME: The sum of all time spend in this tree, in minutes. This time (org-clock-sum ts te (unless (null matcher) (lambda () - (let ((tags-list (org-get-tags-at))) + (let* ((tags-list (org-get-tags-at)) + (org-scanner-tags tags-list) + (org-trust-scanner-tags t)) (eval matcher))))) (goto-char (point-min)) (setq st t) -- 1.7.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 4:34 ` Ilya Shlyakhter @ 2012-03-16 10:35 ` Carsten Dominik 2012-03-16 14:25 ` Nick Dokos 0 siblings, 1 reply; 11+ messages in thread From: Carsten Dominik @ 2012-03-16 10:35 UTC (permalink / raw) To: Ilya Shlyakhter; +Cc: nicholas.dokos, emacs-orgmode Hi Ilya, hi Nick, thanks for looking into this. I am amazed by the deep understanding of Org's internals that shows in this thread. Both patches seem to be OK as far as I can see and can be applied without adverse effects. The patch for org-clock.el will at most achieve a factor of two (because org-get-tags-at is called anyway), but indeed, the patch in org.el can potentially have even more significant effects, when properties are tested in the matcher. Cheers and thanks! - Carsten On 16.3.2012, at 05:34, Ilya Shlyakhter wrote: > Here is a similar patch for org-clock's use of tags/properties matcher. > > On Fri, Mar 16, 2012 at 12:31 AM, Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote: > ,---- > | If your function needs to retrieve the tags including inherited tags > | at the *current* entry, > > 'Function' here refers to the FUNC parameter of org-map-entries, not the MATCHER parameter. > The matcher is constructed by org-make-tags-matcher, so we know everything it does -- > it does not move around and only asks about the current entry's tags and properties. > org-scan-tags only invokes the matcher at the current entry, and sets org-scanner-tags > correctly for that call. > > But, you're right that there is a problem: while org-scan-tags sets org-scanner-tags correctly > before (eval matcher), other users of the matcher -- e.g. org-clock-get-table-data -- might not. > So, org-trust-scanner-tags should be set not in the matcher, but in the function that calls > the matcher. A corrected patch is attached. > > thanks, > > ilya > > > On Thu, Mar 15, 2012 at 11:13 PM, Nick Dokos <nicholas.dokos@hp.com> wrote: > Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote: > >> The attached patch speeds up tags matching ( 50s --> 5s for my most >> common search ), by turning on org-trust-scanner-tags within the >> matcher. >> >> (When it's off, getting a non-inherited property's value causes a call >> to org-entry-properties to fetch all properties into a cache, >> including ALLTAGS; fetching ALLTAGS involves calling >> (org-get-tags-at), which is slow when org-trust-scanner-tags is off.) >> >> Can this cause problems / was this off for a reason? >> > > I haven't looked at your patch carefully enough to know if it will or > will not cause problems, but check the doc for org-map-entries: it has > some guidelines about where the technique can be used and where it > cannot: > > ,---- > | If your function needs to retrieve the tags including inherited tags > | at the *current* entry, you can use the value of the variable > | `org-scanner-tags' which will be much faster than getting the value > | with `org-get-tags-at'. If your function gets properties with > | `org-entry-properties' at the *current* entry, bind `org-trust-scanner-tags' > | to t around the call to `org-entry-properties' to get the same speedup. > | Note that if your function moves around to retrieve tags and properties at > | a *different* entry, you cannot use these techniques. > `---- > > > There are warnings that this variable is for internal dynamical scoping only, > so I suspect you should not mess with the default. If your search can make > the needed guarantees, then you can just wrap it in a let to get the speedup. > Otherwise, it probably should be left alone. > > Nick > > > > <0003-Clocking-work-time-faster-filtering-of-clock-entries.patch> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 10:35 ` Carsten Dominik @ 2012-03-16 14:25 ` Nick Dokos 0 siblings, 0 replies; 11+ messages in thread From: Nick Dokos @ 2012-03-16 14:25 UTC (permalink / raw) To: Carsten Dominik; +Cc: Ilya Shlyakhter, emacs-orgmode, nicholas.dokos Carsten Dominik <carsten.dominik@gmail.com> wrote: > Hi Ilya, hi Nick, > > thanks for looking into this. I am amazed by the deep > understanding of Org's internals that shows in this > thread. > On Ilya's part, certainly - for my part, I have only the vaguest clue about what Ilya did - I just saw a possible red flag. I still have not looked into his patches, but now, thanks to you, I don't have to :-) I can just enjoy the speedup! Nick > Both patches seem to be OK as far as I can see and > can be applied without adverse effects. > The patch for org-clock.el will at most achieve a factor > of two (because org-get-tags-at is called anyway), but > indeed, the patch in org.el can potentially have even > more significant effects, when properties are tested > in the matcher. > > Cheers and thanks! > > - Carsten ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 4:31 ` Ilya Shlyakhter 2012-03-16 4:34 ` Ilya Shlyakhter @ 2012-03-16 6:10 ` Nick Dokos 2012-03-16 14:13 ` Ilya Shlyakhter 2012-03-16 14:20 ` Ilya Shlyakhter 1 sibling, 2 replies; 11+ messages in thread From: Nick Dokos @ 2012-03-16 6:10 UTC (permalink / raw) To: Ilya Shlyakhter; +Cc: nicholas.dokos, emacs-orgmode Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote: > A corrected patch is attached. > One more thing that you'll need to do is put your patches in attachments of a type that will allow patchwork to snag the patch: application/octet-stream does not. And if they don't end up in patchwork, they might get lost. See the "Patches get caught on patchwork" section at http://orgmode.org/worg/org-contribute.html#sec-4-3 Nick ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 6:10 ` Nick Dokos @ 2012-03-16 14:13 ` Ilya Shlyakhter 2012-03-16 16:31 ` Carsten Dominik 2012-03-16 14:20 ` Ilya Shlyakhter 1 sibling, 1 reply; 11+ messages in thread From: Ilya Shlyakhter @ 2012-03-16 14:13 UTC (permalink / raw) Cc: emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 286 bytes --] On 3/16/2012 2:10 AM, Nick Dokos wrote: > One more thing that you'll need to do is put your patches in attachments > of a type that will allow patchwork to snag the patch: Thanks, I was wondering why they're not showing up. Here is another try (attached) for the org.el patch. ilya [-- Attachment #2: 0002-Tags-properties-matcher-faster-matching-by-trusting-.patch --] [-- Type: text/plain, Size: 1043 bytes --] From 95c38b06803aec0787bc2eaab3d0062221390292 Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter <ilya_shl@alum.mit.edu> Date: Fri, 16 Mar 2012 00:10:25 -0400 Subject: [PATCH 2/2] Tags/properties matcher: faster matching by trusting org-scanner-tags * lisp/org.el (org-scan-tags): Bind org-trust-scanner-tags to t while evaluating the matcher, since the matcher is always evaluated at the current entry. TINYCHANGE --- lisp/org.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index ad63213..951f692 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12906,7 +12906,8 @@ headlines matching this string." ;; eval matcher only when the todo condition is OK (and (or (not todo-only) (member todo org-not-done-keywords)) - (let ((case-fold-search t)) (eval matcher))) + (let ((case-fold-search t) (org-trust-scanner-tags t)) + (eval matcher))) ;; Call the skipper, but return t if it does not skip, ;; so that the `and' form continues evaluating -- 1.7.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 14:13 ` Ilya Shlyakhter @ 2012-03-16 16:31 ` Carsten Dominik 0 siblings, 0 replies; 11+ messages in thread From: Carsten Dominik @ 2012-03-16 16:31 UTC (permalink / raw) To: Ilya Shlyakhter; +Cc: emacs-orgmode Applied, thanks! - Carsten On Mar 16, 2012, at 3:13 PM, Ilya Shlyakhter wrote: > On 3/16/2012 2:10 AM, Nick Dokos wrote: > > One more thing that you'll need to do is put your patches in attachments > > of a type that will allow patchwork to snag the patch: > > Thanks, I was wondering why they're not showing up. > Here is another try (attached) for the org.el patch. > > ilya > <0002-Tags-properties-matcher-faster-matching-by-trusting-.patch> - Carsten ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 6:10 ` Nick Dokos 2012-03-16 14:13 ` Ilya Shlyakhter @ 2012-03-16 14:20 ` Ilya Shlyakhter 2012-03-16 16:35 ` Carsten Dominik 1 sibling, 1 reply; 11+ messages in thread From: Ilya Shlyakhter @ 2012-03-16 14:20 UTC (permalink / raw) To: nicholas.dokos; +Cc: emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 216 bytes --] On 3/16/2012 2:10 AM, Nick Dokos wrote: > One more thing that you'll need to do is put your patches in attachments > of a type that will allow patchwork to snag the patch: And here is the org-clock.el patch again. [-- Attachment #2: 0003-Clocking-work-time-faster-filtering-of-clock-entries.patch --] [-- Type: text/plain, Size: 1108 bytes --] From 4f7f91ae62d425f7a89738b28006b1743a6bea4d Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter <ilya_shl@alum.mit.edu> Date: Fri, 16 Mar 2012 00:25:18 -0400 Subject: [PATCH 3/3] Clocking work time: faster filtering of clock entries by trusting org-scanner-tags * lisp/org-clock.el (org-clock-get-table-data): Bind org-scanner-tags to tags-list and org-trust-scanner-tags to t while evaluating the matcher, since the matcher is always evaluated at the current entry. TINYCHANGE --- lisp/org-clock.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 9206608..46d9af8 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -2463,7 +2463,9 @@ TIME: The sum of all time spend in this tree, in minutes. This time (org-clock-sum ts te (unless (null matcher) (lambda () - (let ((tags-list (org-get-tags-at))) + (let* ((tags-list (org-get-tags-at)) + (org-scanner-tags tags-list) + (org-trust-scanner-tags t)) (eval matcher))))) (goto-char (point-min)) (setq st t) -- 1.7.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] tags search: faster tags matcher by trusting scanner tags 2012-03-16 14:20 ` Ilya Shlyakhter @ 2012-03-16 16:35 ` Carsten Dominik 0 siblings, 0 replies; 11+ messages in thread From: Carsten Dominik @ 2012-03-16 16:35 UTC (permalink / raw) To: Ilya Shlyakhter; +Cc: nicholas.dokos, emacs-orgmode This one again did not make it to patchwork, but I have applied it anyway, thanks. - Carsten On Mar 16, 2012, at 3:20 PM, Ilya Shlyakhter wrote: > On 3/16/2012 2:10 AM, Nick Dokos wrote: >> One more thing that you'll need to do is put your patches in attachments >> of a type that will allow patchwork to snag the patch: > > And here is the org-clock.el patch again. > > <0003-Clocking-work-time-faster-filtering-of-clock-entries.patch> - Carsten ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-03-16 16:36 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-03-15 23:16 [PATCH] tags search: faster tags matcher by trusting scanner tags Ilya Shlyakhter 2012-03-16 3:13 ` Nick Dokos 2012-03-16 4:31 ` Ilya Shlyakhter 2012-03-16 4:34 ` Ilya Shlyakhter 2012-03-16 10:35 ` Carsten Dominik 2012-03-16 14:25 ` Nick Dokos 2012-03-16 6:10 ` Nick Dokos 2012-03-16 14:13 ` Ilya Shlyakhter 2012-03-16 16:31 ` Carsten Dominik 2012-03-16 14:20 ` Ilya Shlyakhter 2012-03-16 16:35 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).