Hi Ihor! I tried to follow your advice to improve the patch accordingly. New version attached. Detlef Am Sat, 14 Jan 2023 10:26:17 +0000 schrieb Ihor Radchenko : > Detlef Steuer writes: > > > I now finally followed your advice for that patch. > > > > Attached a diff against a clean git checkout from two > > hours ago. > > Thanks! > Rather than diff, it would help to format a proper patch with author > info and commit message (if you can). > See https://orgmode.org/worg/org-contribute.html#first-patch and > https://orgmode.org/worg/org-contribute.html#commit-messages > > > (I send it privately, because I'm such a noob regarding elisp...) > > Do not be afraid to post on the mailing list in future. > We do not shame anyone or attack in any other way. See > https://www.gnu.org/philosophy/kind-communication.html > > If there are problems with the code, we will help to improve them. If > the problems are also discussed in public, other people will have a > chance to learn as well. > > Let me know if you still prefer private communication. > > > > > mail: steuer@hsu-hh.de > > commit e7574a8d429634112a2eb622759b4eef670ee44c > > Author: Detlef Steuer > > Date: Fri Jan 13 17:55:57 2023 +0100 > > > > Add variable org-icalendar-ttl to ox-icalendar.el > > See https://orgmode.org/worg/org-contribute.html#commit-messages for > our preferred commit message format. > > > +(defcustom org-icalendar-ttl nil > > + "The time to life for the exported calendar. > > +Subscribing clients to the exported ics file can derive the time > > interval +to read the file again from the server. One example of > > such a client is > > Elisp convention is to use double space (" ") between sentences in > docstrings. > > > +the nextcloud calendar, which respects the setting of > > +X-PUBLISHED-TTL, i.e. X-PUBLISHED-TTL:PT1H . > > +See https://icalendar.org/iCalendar-RFC-5545/3-8-2-5-duration.html > > +for a complete description of possiblee values of this option. I.e. > > +PT1H stands for 1 hour, PT0H27M34S for 0 hours, 27 minutes and 34 > > seconds." > > + :group 'org-export-icalendar > > + :type '(choice > > + (const :tag "no refresh" nil) > > + (const :tag "One day" "PT1D") > > + (const :tag "One week" "PT7D") > > + (string :tag "Explizit format"))) > > Maybe just "Other"? > > Also, please add > > :package-version '(Org . "9.7") > > to indicate when the new customization is introduced. > > Finally, please document the new feature in etc/ORG-NEWS file. > > > - (:icalendar-deadline-summary-prefix nil nil > > org-icalendar-deadline-summary-prefix)) > > + (:icalendar-deadline-summary-prefix nil nil > > org-icalendar-deadline-summary-prefix) > > + (:icalendar-ttl nil nil org-icalendar-ttl)) > > > :filters-alist > > '((:filter-headline . org-icalendar-clear-blank-lines)) > > :menu-entry > > @@ -872,24 +889,29 @@ as a communication channel." > > (or (org-string-nw-p org-icalendar-timezone) > > (format-time-string "%Z")) ;; Description. > > (org-export-data (plist-get info :title) info) > > + ;; TTL > > + org-icalendar-ttl > > Please use (plist-get info :icalendar-ttl) here and later rather than > the variable. It will then integrate better with Org's export system. > > > respectively, the name of the calendar, its owner, the timezone > > -used, a short description and the other components included." > > - (concat (format "BEGIN:VCALENDAR > > +used, a short description, the time-to-live resp. refresh period > > and > > "time-to-life"? or maybe "time to life"? >