emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Aaron L. Zeng" <me@bcc32.com>
To: emacs-orgmode@gnu.org
Cc: "Aaron L. Zeng" <me@bcc32.com>
Subject: [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer
Date: Sun, 22 May 2022 14:51:21 -0400	[thread overview]
Message-ID: <20220522185120.2852682-1-me@bcc32.com> (raw)

(I'm resubmitting this patch because my previous submission was in-reply-to
another email which I suspect was ignored.  Would love to get this relatively
simple bug fixed.  Thanks!)

* lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when
org-todo-yesterday intends to call org-agenda-todo-yesterday with the
same interactive arg.  Before this change, the command incorrectly set
the todo state of the task to blank when called with C-u C-u C-u in an
agenda buffer (supposed to bypass any blocked checkboxes/subtasks).

 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 6842bfe9b..b3b9c777b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9666,7 +9666,7 @@ nil or a string to be used for the todo mark." )
   "Like `org-todo' but the time of change will be 23:59 of yesterday."
   (interactive "P")
   (if (eq major-mode 'org-agenda-mode)
-      (apply 'org-agenda-todo-yesterday arg)
+      (org-agenda-todo-yesterday arg)
     (let* ((org-use-effective-time t)
 	   (hour (nth 2 (decode-time (org-current-time))))
 	   (org-extend-today-until (1+ hour)))

             reply	other threads:[~2022-05-22 19:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-22 18:51 Aaron L. Zeng [this message]
2022-05-26  4:35 ` [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer Ihor Radchenko
2022-05-26  5:12   ` Aaron Zeng
  -- strict thread matches above, loose matches on Subject: below --
2022-03-19  3:55 Aaron Zeng
2022-04-11 15:34 ` Aaron L. Zeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220522185120.2852682-1-me@bcc32.com \
    --to=me@bcc32.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).