The following changes since commit 668205f7693e028f15240ffc043e037b411daf81: Backport commit d52c929e3 from Emacs (2022-03-02 23:02:50 -0500) are available in the Git repository at: git@github.com:bcc32/org-mode.git bugfix for you to fetch changes up to 0a073f0b0d7b0eb72f41e2edde4e070ca431ff71: org-todo-yesterday: Fix interactive arg when in agenda buffer (2022-03-18 23:31:37 -0400) ---------------------------------------------------------------- Aaron L. Zeng (1): org-todo-yesterday: Fix interactive arg when in agenda buffer lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
* lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when org-todo-yesterday intends to call org-agenda-todo-yesterday with the same interactive arg. Before this change, the command incorrectly set the todo state of the task to blank when called with C-u C-u C-u in an agenda buffer (supposed to bypass any blocked checkboxes/subtasks). TINYCHANGE --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 54350faee..5e326e765 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -9665,7 +9665,7 @@ nil or a string to be used for the todo mark." ) "Like `org-todo' but the time of change will be 23:59 of yesterday." (interactive "P") (if (eq major-mode 'org-agenda-mode) - (apply 'org-agenda-todo-yesterday arg) + (org-agenda-todo-yesterday arg) (let* ((org-use-effective-time t) (hour (nth 2 (decode-time (org-current-time)))) (org-extend-today-until (1+ hour))) -- 2.33.1
(I'm resubmitting this patch because my previous submission was in-reply-to another email which I suspect was ignored. Would love to get this relatively simple bug fixed. Thanks!) * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when org-todo-yesterday intends to call org-agenda-todo-yesterday with the same interactive arg. Before this change, the command incorrectly set the todo state of the task to blank when called with C-u C-u C-u in an agenda buffer (supposed to bypass any blocked checkboxes/subtasks). TINYCHANGE --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 6842bfe9b..b3b9c777b 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -9666,7 +9666,7 @@ nil or a string to be used for the todo mark." ) "Like `org-todo' but the time of change will be 23:59 of yesterday." (interactive "P") (if (eq major-mode 'org-agenda-mode) - (apply 'org-agenda-todo-yesterday arg) + (org-agenda-todo-yesterday arg) (let* ((org-use-effective-time t) (hour (nth 2 (decode-time (org-current-time)))) (org-extend-today-until (1+ hour))) -- 2.33.3
"Aaron L. Zeng" <me@bcc32.com> writes:
> (I'm resubmitting this patch because my previous submission was in-reply-to
> another email which I suspect was ignored. Would love to get this relatively
> simple bug fixed. Thanks!)
>
> * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when
> org-todo-yesterday intends to call org-agenda-todo-yesterday with the
> same interactive arg. Before this change, the command incorrectly set
> the todo state of the task to blank when called with C-u C-u C-u in an
> agenda buffer (supposed to bypass any blocked checkboxes/subtasks).
Thanks! Applied onto main via 713c15d85.
I have made amendments to the commit message. Function/symbol names
should be quoted as `org-todo-yesterday'.
Best,
Ihor
[-- Attachment #1: Type: text/plain, Size: 915 bytes --] Thanks Ihor! And, noted for the future. On Thu, May 26, 2022 at 12:34 AM Ihor Radchenko <yantar92@gmail.com> wrote: > "Aaron L. Zeng" <me@bcc32.com> writes: > > > (I'm resubmitting this patch because my previous submission was > in-reply-to > > another email which I suspect was ignored. Would love to get this > relatively > > simple bug fixed. Thanks!) > > > > * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when > > org-todo-yesterday intends to call org-agenda-todo-yesterday with the > > same interactive arg. Before this change, the command incorrectly set > > the todo state of the task to blank when called with C-u C-u C-u in an > > agenda buffer (supposed to bypass any blocked checkboxes/subtasks). > > Thanks! Applied onto main via 713c15d85. > > I have made amendments to the commit message. Function/symbol names > should be quoted as `org-todo-yesterday'. > > Best, > Ihor > [-- Attachment #2: Type: text/html, Size: 1357 bytes --]