From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulrich Mueller Subject: Re: Location of OpenDocument style files should be configurable Date: Thu, 29 Dec 2011 19:32:31 +0100 Message-ID: <20220.45631.780613.706617@a1i15.kph.uni-mainz.de> References: <20220.19946.360761.625682@a1i15.kph.uni-mainz.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:60476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKmL-0005bC-NH for emacs-orgmode@gnu.org; Thu, 29 Dec 2011 13:32:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgKmK-0008KH-PK for emacs-orgmode@gnu.org; Thu, 29 Dec 2011 13:32:37 -0500 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:34791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKmK-0008K9-EF for emacs-orgmode@gnu.org; Thu, 29 Dec 2011 13:32:36 -0500 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org >>>>> On Thu, 29 Dec 2011, Achim Gratz wrote: > IMHO, an _installed_ org mode should never heuristically search > any support files -- the location should either be recorded into > org-install.el as a constant or made configurable as a defcustom, > whichever is more appropriate. Such heuristic searches are not uncommon in other elisp packages. But I agree that it's the wrong approach. If the location is known at build time, then it should be recorded somewhere in the lisp code. >> Now my question, could the defconst be changed to a defvar, so that >> we can specify the location in our site-start file? Or, preferably, >> could the etcdir specified in "make" command be honoured in the >> lisp code? > Jambunathan will have to answer that, but a defvar seems the wrong > solution to this problem. Also site-start should probably not be > (mis-)used to configure the behaviour of packages that the user may > not actually use. Well, we don't configure the behaviour, but just fix a wrong path. Also Gentoo's site-start file requires org-install if org-mode is installed on the user's system. So, for the user there won't be a visible difference if the path is defined in org-install or in site-start. Of course, it is preferred if the upstream package gets things right, so that we don't have to adjust them on the distro level. Ulrich