emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: tomas@tuxteam.de
To: Jeremy Cowgar <jeremy@cowgar.com>
Cc: Emacs-orgmode <emacs-orgmode-bounces+jeremy=cowgar.com@gnu.org>,
	emacs-orgmode@gnu.org
Subject: Re: [PATCH] Treat :tangle-mode as an octal value not integer
Date: Wed, 29 Sep 2021 09:21:51 +0200	[thread overview]
Message-ID: <20210929072151.GD6367@tuxteam.de> (raw)
In-Reply-To: <7e1c208b9fa8845adff5e3c45d6f086b@cowgar.com>

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

On Wed, Sep 29, 2021 at 02:55:46AM -0400, Jeremy Cowgar wrote:
> On 2021-09-29 02:39, tomas@tuxteam.de wrote:
> >On Tue, Sep 28, 2021 at 10:54:48AM -0400, Jeremy Cowgar wrote:
> >>As an org user I would expect :tangle-mode 0660 to produce a file that
> >>has user rw, group rw, other nothing. Instead, what really happens
> >>currently is 0660 is treated as an integer which is actually
> >>3140. This produces unexpected file permissions.
> >>
> >
> >Hm. This looks dangerous: interpreting an integer as octal just
> >due to the context?
> >
> >I do understand why, but still...
> >
> >Why not recommend Elisp's explicit syntax for octal representation,
> >i.e. :tangle-mode #o660? And put a prominent note in the docs,
> >of course.
> 
> Are you suggesting this currently works or that the patch should be
> changed to make that work? A quick try on my local system (pre-patch),
> I receive the error:
> 
>   Wrong type argument: fixnump, "#o660"

Oh. It seems Org converts that to string based on its own
rules instead of on Elisp's.

Note that I'm not dead set /against/ your proposal. I was pointing
out a possible inconsistency and arguing for some reflection, however
it may turn out.

I'd have a slight preference for the #oXXX variant (and for Org
agreeing with Elisp on what a number is ;-) but it's just that,
a slight preference.

The UNIX shell's convention "leading zero to denote base 8" (coming 
from C, I don't know where that comes from) is one not very happy
hack, IMO. But if that's what is in people's muscle memory, so
be it ;-)

Cheers
 - t

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2021-09-29  7:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 14:54 Jeremy Cowgar
2021-09-29  6:39 ` tomas
2021-09-29  6:55   ` Jeremy Cowgar
2021-09-29  7:21     ` tomas [this message]
2021-09-29  7:52     ` dkrm
2021-09-29  8:22       ` tomas
2021-09-29  9:29         ` Gyro Funch
2021-09-29 11:07           ` tomas
2021-09-29 13:17             ` Jeremy Cowgar
2021-09-29 13:55               ` tomas
2021-09-29  7:10   ` Greg Minshall
2021-09-29 11:35 ` Bastien
2021-09-29 13:48 ` Timothy
2021-09-29 14:26   ` tomas
2021-09-29 14:58     ` Timothy
2021-09-29 15:13       ` Jeremy Cowgar
2021-09-30 18:13         ` Timothy
2021-09-29 15:14       ` tomas
2021-09-29 17:18     ` Greg Minshall
2021-09-29 18:15       ` tomas
2021-11-18 12:04       ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929072151.GD6367@tuxteam.de \
    --to=tomas@tuxteam.de \
    --cc=emacs-orgmode-bounces+jeremy=cowgar.com@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=jeremy@cowgar.com \
    --subject='Re: [PATCH] Treat :tangle-mode as an octal value not integer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).