emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Morgan Willcock <mwillcock@precedence.co.uk>
To: emacs-orgmode@gnu.org
Cc: Morgan Willcock <mwillcock@precedence.co.uk>
Subject: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil
Date: Wed, 18 Aug 2021 00:07:35 +0100	[thread overview]
Message-ID: <20210817230735.13336-1-mwillcock@precedence.co.uk> (raw)

* lisp/ox-ascii.el (org-ascii--justify-lines): Ensure that
`indent-tabs-mode' is nil when applying indentation to justify lines.
This prevents tab characters from appearing in the export when
`indent-tabs-mode' still has its default value of t.  TINYCHANGE

I've attached a patch to fix an issue where tab characters are generated by
the ASCII exporter when `indent-tabs-mode' has its default value of t.

Here is a simple test case which generates tabs with 'emacs -Q':

  (insert "#+TITLE: My Title\n"
	  "#+OPTIONS: author:nil\n"
	  "#+OPTIONS: toc:nil\n")
  (with-current-buffer "*Org ASCII Export*"

I haven't gone through the FSF copyright assignment process but I'm assuming
this is OK based on the line count.


 lisp/ox-ascii.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lisp/ox-ascii.el b/lisp/ox-ascii.el
index d1762d41c..176542661 100644
--- a/lisp/ox-ascii.el
+++ b/lisp/ox-ascii.el
@@ -480,6 +480,9 @@ HOW determines the type of justification: it can be `left',
     (insert s)
     (goto-char (point-min))
     (let ((fill-column text-width)
+          ;; Ensure that `indent-tabs-mode' is nil so that indentation
+          ;; will always be achieved using spaces rather than tabs.
+          (indent-tabs-mode nil)
 	  ;; Disable `adaptive-fill-mode' so it doesn't prevent
 	  ;; filling lines matching `adaptive-fill-regexp'.
 	  (adaptive-fill-mode nil))

             reply	other threads:[~2021-08-17 23:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 23:07 Morgan Willcock [this message]
2021-08-31 11:59 ` [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil Timothy
2021-08-31 12:42   ` Morgan Willcock
2021-08-31 12:54     ` Timothy
2021-09-19 13:13 ` Timothy
2021-09-19 15:30   ` Morgan Willcock
2021-09-19 17:02     ` Timothy
  -- strict thread matches above, loose matches on Subject: below --
2021-08-17 22:28 Morgan Willcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817230735.13336-1-mwillcock@precedence.co.uk \
    --to=mwillcock@precedence.co.uk \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).