emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-macs: Allow specifying relative time in hours
@ 2021-01-05  0:48 Daniel Gröber
  2021-01-25  3:23 ` Kyle Meyer
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Gröber @ 2021-01-05  0:48 UTC (permalink / raw)
  To: emacs-orgmode

This adds support for date expressions such as +12h to
org-matcher-time. The regexp this function uses to parse such relative
expressions already includes the "h" character but doesn't actually
handle that case.

AFAICT org-mode commit ec921a2a68 ("Support hourly repeat cookies")
neglected to add support here.
---
 doc/org-manual.org | 14 ++++++++------
 lisp/org-macs.el   |  5 +++--
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index b015b502c..740549cf5 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -6052,15 +6052,17 @@ various inputs are interpreted, the items filled in by Org mode are in
 | =2012-w04-5=   | \rArr{} Same as above                           |
 
 Furthermore you can specify a relative date by giving, as the /first/
-thing in the input: a plus/minus sign, a number and a letter---=d=,
-=w=, =m= or =y=---to indicate change in days, weeks, months, or
-years.  With a single plus or minus, the date is always relative to
-today.  With a double plus or minus, it is relative to the default
-date.  If instead of a single letter, you use the abbreviation of day
-name, the date is the Nth such day, e.g.:
+thing in the input: a plus/minus sign, a number and a letter---=h=,
+=d=, =w=, =m= or =y=---to indicate a change in hours, days, weeks,
+months, or years.  With =h= the date is relative to the current time,
+with the other letters and a single plus or minus, the date is
+relative to today at 00:00.  With a double plus or minus, it is
+relative to the default date.  If instead of a single letter, you use
+the abbreviation of day name, the date is the Nth such day, e.g.:
 
 | =+0=    | \rArr{} today                       |
 | =.=     | \rArr{} today                       |
+| =+2h=   | \rArr{} two hours from now          |
 | =+4d=   | \rArr{} four days from today        |
 | =+4=    | \rArr{} same as +4d                 |
 | =+2w=   | \rArr{} two weeks from today        |
diff --git a/lisp/org-macs.el b/lisp/org-macs.el
index 56afdf6ef..d40ed1a04 100644
--- a/lisp/org-macs.el
+++ b/lisp/org-macs.el
@@ -1228,10 +1228,11 @@ Return 0. if S is not recognized as a valid value."
        ((string= s "<tomorrow>") (+ 86400.0 today))
        ((string= s "<yesterday>") (- today 86400.0))
        ((string-match "\\`<\\([-+][0-9]+\\)\\([hdwmy]\\)>\\'" s)
-	(+ today
+	(+ (if (string= (match-string 2 s) "h") (float-time) today)
 	   (* (string-to-number (match-string 1 s))
 	      (cdr (assoc (match-string 2 s)
-			  '(("d" . 86400.0)   ("w" . 604800.0)
+			  '(("h" . 3600.0)
+			    ("d" . 86400.0)   ("w" . 604800.0)
 			    ("m" . 2678400.0) ("y" . 31557600.0)))))))
        ((string-match org-ts-regexp0 s) (org-2ft s))
        (t 0.)))))
-- 
2.20.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] org-macs: Allow specifying relative time in hours
  2021-01-05  0:48 [PATCH] org-macs: Allow specifying relative time in hours Daniel Gröber
@ 2021-01-25  3:23 ` Kyle Meyer
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Meyer @ 2021-01-25  3:23 UTC (permalink / raw)
  To: Daniel Gröber; +Cc: emacs-orgmode

Daniel Gröber writes:

> This adds support for date expressions such as +12h to
> org-matcher-time. The regexp this function uses to parse such relative
> expressions already includes the "h" character but doesn't actually
> handle that case.
>
> AFAICT org-mode commit ec921a2a68 ("Support hourly repeat cookies")
> neglected to add support here.

Thanks for the analysis and patch.  This looks good to me.  Applied
(aeb9f036f), adding a changelog message to the patch and a TINYCHANGE
cookie (see <https://orgmode.org/worg/org-contribute.html>).

I've also followed up your commit with a commit that adds a few tests
for org-matcher-time, including for h.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-25  3:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05  0:48 [PATCH] org-macs: Allow specifying relative time in hours Daniel Gröber
2021-01-25  3:23 ` Kyle Meyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).