emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] x11idle: Make installation a little smoother
@ 2020-10-25 10:57 Adam Spiers
  2020-10-29  3:44 ` Kyle Meyer
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Spiers @ 2020-10-25 10:57 UTC (permalink / raw)
  To: emacs-orgmode

Fix a -Wimplicit-int compiler warning, and make it more obvious how to
obtain scrnsaver.h on three of the most popular Linux distros.

Signed-off-by: Adam Spiers <orgmode@adamspiers.org>
---
 contrib/scripts/x11idle.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/contrib/scripts/x11idle.c b/contrib/scripts/x11idle.c
index 22cefe1e6..b8db27560 100644
--- a/contrib/scripts/x11idle.c
+++ b/contrib/scripts/x11idle.c
@@ -1,4 +1,9 @@
+/* This header file is provided by the libxss-dev package on Debian,
+ * by the libXss-devel rpm on openSUSE, and the libXScrnSaver-devel
+ * rpm on Fedora.
+ */
 #include <X11/extensions/scrnsaver.h>
+
 #include <stdio.h>
 
 /* Based on code from
@@ -7,7 +12,7 @@
  * compile with 'gcc -l Xss x11idle.c -o x11idle' and copy x11idle into your
  * path
  */
-main() {
+int main() {
     XScreenSaverInfo *info = XScreenSaverAllocInfo();
     //open the display specified by the DISPLAY environment variable
     Display *display = XOpenDisplay(0);
-- 
2.28.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x11idle: Make installation a little smoother
  2020-10-25 10:57 [PATCH] x11idle: Make installation a little smoother Adam Spiers
@ 2020-10-29  3:44 ` Kyle Meyer
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Meyer @ 2020-10-29  3:44 UTC (permalink / raw)
  To: Adam Spiers; +Cc: emacs-orgmode

Adam Spiers writes:

> Fix a -Wimplicit-int compiler warning, and make it more obvious how to
> obtain scrnsaver.h on three of the most popular Linux distros.

Thanks, sounds good.

Note that commits in the Org repo typically follow the Emacs convention
of including a changelog-like entry.  But that doesn't matter for this
case because it's contrib/ (which, by the way, is slated for removal
from this repo: <https://orgmode.org/list/87wnzfy60h.fsf@bzg.fr>).

> Signed-off-by: Adam Spiers <orgmode@adamspiers.org>

That doesn't carry any meaning in this project :)

Pushed (2b3bbf361).


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-29  3:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-25 10:57 [PATCH] x11idle: Make installation a little smoother Adam Spiers
2020-10-29  3:44 ` Kyle Meyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).