emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Sebastian Reuße" <seb@wirrsal.net>
To: emacs-orgmode@gnu.org
Subject: [BUG] org-sort-entries errors out when headline is empty
Date: Tue, 13 Mar 2018 17:51:43 +0100	[thread overview]
Message-ID: <20180313165145.27160-1-seb@wirrsal.net> (raw)

So, I’ve noticed that when sorting a subtree (alphabetically or numerically),
‘org-sort-entries’ will raise an error arising from the call to
‘org-sort-remove-invisible’ (lines 8761 and 8766 in bc7b24d0d).

I’m following up with a test. The error is triggered by the capture group in
‘org-complex-heading-regexp’ returning nil, which is then passed on to
‘org-sort-remove-invisible’, which expects a string and chokes on the nil.

As for a fix, the quick fix would be guarding against this case in
‘org-sort-remove-invisible’, but that seemed a bit meh since sanitation should
probably be handled higher up.

An alternative is to guard inside ‘org-sort-entries’. I’m following up with an
implementation of this.

I was also wondering if it might make sense to tweak
‘org-complex-heading-regexp’ so that the respective capture group captures an
empty string. This could be achieved by making the title group greedy again
(reverting 9d334897e). Whether we want this probably depends on the motivation
for 9d334897e. However, doing so would be more consistent with the org-elements
API, which does assign a tag list to the title property when the heading is
otherwise empty.

Any thoughts?

Kind regards,
SR

-- 
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay

next             reply	other threads:[~2018-03-13 16:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 16:51 Sebastian Reuße [this message]
2018-03-13 16:51 ` [PATCH 1/2] Extend org-sort-entries test Sebastian Reuße
2018-03-13 16:51 ` [PATCH 2/2] Guard against empty headings when sorting Sebastian Reuße
2018-03-20  8:53 ` [BUG] org-sort-entries errors out when headline is empty Nicolas Goaziou
2018-03-23 10:43   ` Sebastian Reuße
2018-04-20  9:30     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313165145.27160-1-seb@wirrsal.net \
    --to=seb@wirrsal.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).