From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Sebastian=20Reu=C3=9Fe?= Subject: [PATCH 3/6] Fix org-table-sort-lines test Date: Sun, 11 Mar 2018 16:43:49 +0100 Message-ID: <20180311154352.16920-3-seb@wirrsal.net> References: <20180311154352.16920-1-seb@wirrsal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev39f-0000VM-8o for emacs-orgmode@gnu.org; Sun, 11 Mar 2018 11:45:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ev39e-0008MK-FV for emacs-orgmode@gnu.org; Sun, 11 Mar 2018 11:44:59 -0400 Received: from wirrsal.net ([188.68.36.149]:42794 helo=mail.wirrsal.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ev39e-0008Ls-8r for emacs-orgmode@gnu.org; Sun, 11 Mar 2018 11:44:58 -0400 In-Reply-To: <20180311154352.16920-1-seb@wirrsal.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Cc: =?UTF-8?q?Sebastian=20Reu=C3=9Fe?= * test-org-table.el (test-org-table/sort-lines): Fix and improve testcase. Sorting and reversing =C2=ABa C b=C2=BB should result in =C2=ABC b a=C2=BB= , not in =C2=ABb a C=C2=BB. This test did not fail previously only because org-table-sort-lines had an issue whereby sorts were always case-sensitive. --- testing/lisp/test-org-table.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/testing/lisp/test-org-table.el b/testing/lisp/test-org-table= .el index 850080c7a..d90caa8e9 100644 --- a/testing/lisp/test-org-table.el +++ b/testing/lisp/test-org-table.el @@ -1691,13 +1691,13 @@ (buffer-string)))) ;; Sort alphabetically. (should - (equal "| a | x |\n| b | 4 |\n| c | 3 |\n" - (org-test-with-temp-text "| a | x |\n| c | 3 |\n| b | 4 |\n" + (equal "| a | x |\n| B | 4 |\n| c | 3 |\n" + (org-test-with-temp-text "| a | x |\n| c | 3 |\n| B | 4 |\n" (org-table-sort-lines nil ?a) (buffer-string)))) (should - (equal "| c | 3 |\n| b | 4 |\n| a | x |\n" - (org-test-with-temp-text "| a | x |\n| c | 3 |\n| b | 4 |\n" + (equal "| c | 3 |\n| B | 4 |\n| a | x |\n" + (org-test-with-temp-text "| a | x |\n| c | 3 |\n| B | 4 |\n" (org-table-sort-lines nil ?A) (buffer-string)))) ;; Sort alphabetically with case. @@ -1707,7 +1707,7 @@ (org-table-sort-lines t ?a) (buffer-string)))) (should - (equal "| b |\n| a |\n| C |\n" + (equal "| C |\n| b |\n| a |\n" (org-test-with-temp-text "| a |\n| C |\n| b |\n" (org-table-sort-lines nil ?A) (buffer-string)))) --=20 2.16.2