From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Garbs <mitch@cgarbs.de>
Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel
Date: Wed, 2 Aug 2017 22:24:04 +0200
Message-ID: <20170802202404.lltnk4rs5mt7opgw@cgarbs.de>
References: <87fudze7y4.fsf@nicolasgoaziou.fr>
	<1500061387-3353-1-git-send-email-mitch@cgarbs.de>
	<87379no75t.fsf@nicolasgoaziou.fr>
	<20170801212052.lc64vzvuluglctqq@cgarbs.de>
	<87ini7q721.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mitch@cgarbs.de>) id 1dd0Bi-0005kg-Ms
	for emacs-orgmode@gnu.org; Wed, 02 Aug 2017 16:24:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mitch@cgarbs.de>) id 1dd0Be-0003OH-Ch
	for emacs-orgmode@gnu.org; Wed, 02 Aug 2017 16:24:14 -0400
Received: from mspool3.srv.dfn.de ([2001:638:d:c401::3]:42813
	helo=mail.shuttle.de)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mitch@cgarbs.de>) id 1dd0Be-0003Lo-5k
	for emacs-orgmode@gnu.org; Wed, 02 Aug 2017 16:24:10 -0400
Received: from yggdrasil.mitch.h.shuttle.de (p2E5B4EC6.dip0.t-ipconnect.de
	[46.91.78.198])
	by mspool3.srv.dfn.de (Postfix) with ESMTPSA id C6830EAC
	for <emacs-orgmode@gnu.org>; Wed,  2 Aug 2017 22:24:05 +0200 (CEST)
Received: from mitch by yggdrasil.mitch.h.shuttle.de with local (Exim 4.89)
	(envelope-from <mitch@cgarbs.de>) id 1dd0BY-0003T1-NG
	for emacs-orgmode@gnu.org; Wed, 02 Aug 2017 22:24:04 +0200
Content-Disposition: inline
In-Reply-To: <87ini7q721.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hi,

On Wed, Aug 02, 2017 at 12:03:50AM +0200, Nicolas Goaziou wrote:
> Christian Garbs <mitch@cgarbs.de> writes:

> > Some of your proposed changes apply to ob-C.el as well.  I could
> > prepare a different patch for that (under which topic?),
> 
> Depending on the size of the changes, it could be "Tiny changes", "Small
> refactoring"...

I'll have a look at it if time permits.  I should probably write some
documentation for ob-vala first.

> (BTW, would you want to write some for "ob-vala.el"?).

Oooh, I like testing!  After having I short look at the ob-C tests I
think I should be able to come up with some similar test cases.

> Could you provide an ORG-NEWS entry about the new file?

Yes, I'll try that, too.

The next iteration of the patch should include ob-vala.el itself, some
tests and an ORG-NEWS entry.


Regarding the lexical-binding:  How can I check if byte-compiling is
successful?

Regards,
Christian
-- 
....Christian.Garbs....................................https://www.cgarbs.de

Murphy's Laws of Combat:
21. Friendly fire isn't.