From: Vladimir Lomov <lomov.vl@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: Write file while editing babel code block doesn't work as expected [8.3.4 (release_8.3.4-778-g8127b3 @ /usr/local/share/emacs/site-lisp/org/)]
Date: Sun, 15 May 2016 19:00:16 +0800 [thread overview]
Message-ID: <20160515110016.GB1188@smoon.vl-lomov.ru> (raw)
In-Reply-To: <87h9dzwyzw.fsf@saiph.selenimh>
Hello,
** Nicolas Goaziou [2016-05-15 09:40:03 +0200]:
> Hello,
>
> Vladimir Lomov <lomov.vl@gmail.com> writes:
>
>> I have small example that worked before the commit, please see attached
>> Org document.
>
> While it's true this worked before, I don't consider it to be
> a regression. There was no guarantee that `save-buffer' would save the
> source buffer. In fact, I think instrumenting `save-buffer' is not
> a good idea, because it is surprising. Usually, minor modes change
> bindings instead of altering functions.
>
> You can bind `org-edit-src-save' to F2 in this case.
Correct me if I understand you wrong, but you suggest to bind ~F2~ key
to ~org-edit-src-save~. But then this will work only in Org buffer, and
how about LaTeX mode then. Or I should bind ~F2~ to something like that:
(global-set-key [f2]
(if (functionp org-edit-src-save) org-edit-src-save save-buffer))
(don't test this code, just idea, may be this code won't work or even
there is more elegant code and idea).
On second thought, I considered org-src buffer as auxiliary buffer,
depending on (main) Org document buffer, so saving org-src buffer should
save Org document buffer. I agree that there should be possibility to
save org-src buffer and if ~write-buffer~ works it is Ok and it is Ok to
call it manually. This is just my thoughts.
>
> Regards,
>
> --
> Nicolas Goaziou
---
WBR, Vladimir Lomov
--
Q: Why does Washington have the most lawyers per capita and
New Jersey the most toxic waste dumps?
A: God gave New Jersey first choice.
next prev parent reply other threads:[~2016-05-15 11:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 23:44 Bug: Write file while editing babel code block doesn't work as expected [8.3.4 (release_8.3.4-778-g8127b3 @ /usr/local/share/emacs/site-lisp/org/)] David Dynerman
2016-05-11 9:20 ` Phil Hudson
2016-05-11 21:26 ` Nicolas Goaziou
2016-05-13 0:00 ` Aaron Ecay
2016-05-13 12:12 ` Nicolas Goaziou
2016-05-13 19:05 ` Aaron Ecay
2016-05-15 4:11 ` Vladimir Lomov
2016-05-15 7:40 ` Nicolas Goaziou
2016-05-15 11:00 ` Vladimir Lomov [this message]
2016-05-15 17:03 ` Nicolas Goaziou
2016-05-16 2:48 ` Vladimir Lomov
2016-05-16 9:29 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160515110016.GB1188@smoon.vl-lomov.ru \
--to=lomov.vl@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).