From: James Harkins <jamshark70@qq.com>
To: orgmode <emacs-orgmode@gnu.org>
Subject: Re: after-todo-statistics hook for checkboxes
Date: Wed, 15 Oct 2014 21:38:43 +0800 [thread overview]
Message-ID: <20141015213843.6003d235@hjh-e431> (raw)
In-Reply-To: <87a94xk2ts.wl-jamshark70@qq.com>
[-- Attachment #1: Type: text/plain, Size: 1990 bytes --]
On Wed, 15 Oct 2014 19:08:31 +0800
James Harkins <jamshark70@qq.com> wrote:
> org-after-todo-statistics-hook allows you to do something to a node after its statistics cookie got updated. Unfortunately, it does this only for TODO subheadings and it doesn't work with checkboxes.
> (snip)
> Actually... after a little more poking around, the problem seems to be that org-update-checkbox-count refers to no hooks whatsoever. Should it go toward the end, here? (Untested.)
>
> (mapc (lambda (cookie)
> (let* ((beg (car cookie))
> (end (nth 1 cookie))
> (percentp (nth 2 cookie))
> (checked (car (nth 3 cookie)))
> (total (cdr (nth 3 cookie)))
> (new (if percentp
> (format "[%d%%]" (/ (* 100 checked)
> (max 1 total)))
> (format "[%d/%d]" checked total))))
> (goto-char beg)
> (insert new)
> (delete-region (point) (+ (point) (- end beg)))
> (run-hook-with-args 'org-after-todo-statistics-hook
> checked (- total checked))
> (when org-auto-align-tags (org-fix-tags-on-the-fly))))
> cookies-list))))
After dinner, I tested the change that I had speculated about, and... it works exactly correctly.
* TODO Test A [0/2]
** TODO Test B [0/2]
- [ ] 1
- [ ] 2
** TODO Test C
C-c C-c on "1" (with my hook function[1]):
* TODO Test A [0/2]
** INPROG Test B [1/2]
- [X] 1
- [ ] 2
** TODO Test C
C-c C-c on "2":
* INPROG Test A [1/2]
** DONE Test B [2/2]
- [X] 1
- [X] 2
** TODO Test C
So I'm submitting this as a TINYCHANGE patch. Do with it as you will, although I will keep using it locally until something better comes along.
hjh
[1]
(defun hjh-org-summary-todo (n-done n-not-done)
"Switch entry to DONE when all subentries are done, to TODO otherwise."
(let (org-log-done org-log-states) ; turn off logging
(org-todo
(if (= n-not-done 0)
"DONE"
(if (= n-done 0) "TODO" "INPROG")))))
(add-hook 'org-after-todo-statistics-hook 'hjh-org-summary-todo)
[-- Attachment #2: 0001-Run-org-after-todo-statistics-hook-when-toggling-a-c.patch --]
[-- Type: text/x-patch, Size: 902 bytes --]
From cbb4c589b1ed65152485ea2b687eb54ff7e2e478 Mon Sep 17 00:00:00 2001
From: James Harkins <jamshark70@dewdrop-world.net>
Date: Wed, 15 Oct 2014 21:32:28 +0800
Subject: [PATCH] Run org-after-todo-statistics-hook when toggling a checkbox
* org-list.el (org-update-checkbox-count): Run
org-after-todo-statistics-hook for each affected cookie.
TINYCHANGE
---
lisp/org-list.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lisp/org-list.el b/lisp/org-list.el
index b1d47c9..2fdda6b 100644
--- a/lisp/org-list.el
+++ b/lisp/org-list.el
@@ -2553,6 +2553,8 @@ With optional prefix argument ALL, do this for the whole buffer."
(goto-char beg)
(insert new)
(delete-region (point) (+ (point) (- end beg)))
+ (run-hook-with-args 'org-after-todo-statistics-hook
+ checked (- total checked))
(when org-auto-align-tags (org-fix-tags-on-the-fly))))
cookies-list))))
--
1.7.9.5
next prev parent reply other threads:[~2014-10-15 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 11:08 after-todo-statistics hook for checkboxes James Harkins
2014-10-15 13:38 ` James Harkins [this message]
2014-10-15 13:45 ` Nicolas Goaziou
[not found] ` <1491661ce88.27cd.0bb60a3c7e492ea180363c67eb170725@qq.com>
2014-10-16 1:01 ` James Harkins
2014-10-16 16:39 ` Nicolas Goaziou
2014-10-16 23:23 ` James Harkins
2014-10-17 20:22 ` Nicolas Goaziou
2014-10-18 2:21 ` James Harkins
2014-10-18 7:31 ` Nicolas Goaziou
2014-10-20 12:46 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015213843.6003d235@hjh-e431 \
--to=jamshark70@qq.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).