emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Christian Kellermann <ckeen@pestilenz.org>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org, Christian Kellermann <ckeen@pestilenz.org>
Subject: Re: [PATCH] Improve usage of odt content templates
Date: Mon, 19 May 2014 18:41:17 +0200	[thread overview]
Message-ID: <20140519164117.GA15335@pestilenz.org> (raw)
In-Reply-To: <87zjidd9pn.fsf@gmail.com>


* Nicolas Goaziou <n.goaziou@gmail.com> [140519 18:16]:
> It is already possible to override the varible file-wise with:
>   #+BIND: org-odt-content-template-file "somefile"
> I'm not sure it is worth adding another keyword. OTOH, there's also
> ODT_STYLES_FILE and they are quite symmetric, so one could expect to be
> able to set both. But then, `org-odt-content-template-file''s docstring
> needs to be updated, and the feature should be documented in the manual.

I first thought about using ODT_STYLES_FILE in the list form and
pick out the content.xml from there, but maybe that's a bit unexpected
as one might use a different content than from the style.

But the control flow as it is now would need to be refactored to
make this a nice patch too.

I shall resend this patch with proper docstrings and manual patches
if you like.

> Also, it should be
>   (:odt-content-template-file "ODT_CONTENT_TEMPLATE_FILE" nil org-odt-content-template-file t)

Ah of course.

> > * Avoid inserting the document title as the first thing in the
> > document contents, as there already is a title set in a title page
> > in the template. As org-mode already sets the title data tag this
> > can be used in the template to generate the correct title. However
> > inserting the title as text is not desireable in that scenario.
> I think this is a more general issue: should we implement an
>   #+OPTIONS: title:nil
> feature? I think it makes some sense since we already have date:nil and
> author:nil. In any case, keywords are not meant to be used for booleans.
> This should be an OPTIONS item.

I don't feel qualified to decide on this. I can provide the needed
patches though.

Thanks for your review!



May you be peaceful, may you live in safety, may you be free from
suffering, and may you live with ease.

  parent reply	other threads:[~2014-05-19 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 10:42 [PATCH] Improve usage of odt content templates Christian Kellermann
2014-05-19 16:17 ` Nicolas Goaziou
2014-05-19 16:34   ` Rasmus
2014-05-20  7:56     ` Christian Kellermann
2014-05-20  8:37     ` Eric Abrahamsen
2014-05-20 10:39       ` Detlef Steuer
2014-05-19 16:41   ` Christian Kellermann [this message]
2014-05-21 12:47     ` Nicolas Goaziou
2014-05-22  8:00       ` Detlef Steuer
2014-05-22  8:23         ` Rasmus
2014-05-20 15:12   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140519164117.GA15335@pestilenz.org \
    --to=ckeen@pestilenz.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).