From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viktor Rosenfeld Subject: Re: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Date: Sat, 25 May 2013 19:03:22 +0200 Message-ID: <20130525170322.GA734@kenny.local> References: <87hahrmabq.fsf@pank.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:41840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgHsT-0003iI-HN for emacs-orgmode@gnu.org; Sat, 25 May 2013 13:03:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgHsP-0000GQ-DD for emacs-orgmode@gnu.org; Sat, 25 May 2013 13:03:33 -0400 Received: from mail-bk0-x234.google.com ([2a00:1450:4008:c01::234]:47145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgHsP-0000GC-6L for emacs-orgmode@gnu.org; Sat, 25 May 2013 13:03:29 -0400 Received: by mail-bk0-f52.google.com with SMTP id mz10so3005242bkb.39 for ; Sat, 25 May 2013 10:03:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87hahrmabq.fsf@pank.eu> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: alan.schmitt@polytechnique.org, emacs-orgmode@gnu.org Hi Rasmus, Rasmus wrote: > The following message is a courtesy copy of an article > that has been posted to gmane.emacs.orgmode as well. > > Alan Schmitt writes: > > > Hello, > > > > Viktor Rosenfeld writes: > > > >> Hi Robert, > >> > >> Robert Klein wrote: > >> > >>> Hi, > >>> > >>> FWIW, from a users view it would be nice if: > >>> > >>> - Use Author/Email information from org file > >>> - If not present use information from LCO file > >>> - if neither org file nor LCO file has any information use > >>> user-full-name and user-email-address > >>> > >>> Could this be solved by having several e.g. `setkomavar{fromname}' > >>> and so on in the tex file, so is created as follows: > > I'd go with 'no'. It's not aesthetically pleasing and I don't want my > output to look like LyX. When feasible we should go for beautiful > output. This isn't always the case at the moment, but still. I agree that there should not be multiple instances of, e.g., \setkomavar{fromname} in the TeX file. I must have overlooked that bit in the original mail. > On a side-note, Viktor: this seems to be the default in scrletter > anyway: > >>> add \setkomavar{signature}{\usekomavar{fromname}} > Could we remove it? I'd like us to get to a more clean template (C-e > # koma-letter RET). I think so, yes. > >> This is what is implemented by the latest patch > >> (http://thread.gmane.org/gmane.emacs.orgmode/72430/focus=72525). > > > > I'm waiting for Rasmus's confirmation that it works for him before > > committing it. > > Thanks and sorry for the wait. No it didn't work for me. My user > name was always overwritten by "". . . I couldn't figure out why. Hmm, that's too bad. I tested it pretty thoroughly. Could you maybe trace the contents of the variable by adding calls to message in various places? > I've attached a patch that work for me (it goes on top of Viktor's > patch 148c737ae79f3a98d8e93147c2d0ec0db3a2389a). It allows for nil > and it gets up-to-date default values by default. In my book it's a > bit more clean 'cause it doesn't rely on hooks. It does, introduce a > new helper function to distinguish between a function value (which are > default for the two variables) and a string value (and nil for that > matter). I don't know if this is undesirable. It would crash if you > set the variables to a symbol that isn't nil and isn't a function. Did you send the patch? I did not receive it and it's not available on gmane. Cheers, Viktor > > It seems to work in mine and Viktor's use-case (to the best of my > testing ability). > > –Rasmus > > -- > ⠠⠵ >