From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viktor Rosenfeld Subject: Re: [patch] ox-koma-letter.el: subject changes [2/4] Date: Tue, 21 May 2013 17:52:40 +0200 Message-ID: <20130521155240.GA55239@client199-78.wlan.hu-berlin.de> References: <87wqqusder.fsf@pank.eu> <87obc6scty.fsf@pank.eu> <87y5b9o6ij.fsf@pank.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ueorp-0007n7-MT for emacs-orgmode@gnu.org; Tue, 21 May 2013 11:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ueork-0000lI-W2 for emacs-orgmode@gnu.org; Tue, 21 May 2013 11:52:49 -0400 Received: from mail-bk0-x232.google.com ([2a00:1450:4008:c01::232]:51977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ueork-0000lA-Pe for emacs-orgmode@gnu.org; Tue, 21 May 2013 11:52:44 -0400 Received: by mail-bk0-f50.google.com with SMTP id ik5so512106bkc.37 for ; Tue, 21 May 2013 08:52:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Alan Schmitt Cc: emacs-orgmode@gnu.org, Rasmus Hi, Alan Schmitt wrote: > Rasmus writes: > > > I found a "bug" in that the subject variable should be a list cf. the > > KOMA manual. This patch fixes this. > > > > It's pretty complex for something so simple, and I might be inclined > > to admit to the "put it in a LCO"-file approach might be better. > > I'd really like to have a second opinion on this. Viktor? I think this patch is great simply from the usability standpoint of being able to configure the behavior through customize (which I don't generally use, but admit that it's a good thing). I found a few issues though: 1. Choosing `No export' in customize results `\KOMAoption{subject}{nil}'. 2. It is not possible to set a subject format in the LCO file because if `org-koma-letter-subject-format' is set, the KOMA option will be overwritten explicitly, and if it is set to `nil' then the subject is inhibited altogether. This is actually a problem with the old code as well. One way out of this is to only print the subject line (i.e., `\setkomavar{subject}{.}' if `org-koma-letter-subject-format' is nil and and fix `noexport' to hide the subject (i.e., inhibit `\setkomavar{subject}{.}'). Is this the entended behaviour? I'll try to post a patch for this later tonight. 3. I'm not a big fan of the parentheses in the subject:(.) syntax, but if that's required to use an option list with multiple values I think it's okay. It would be nice to be able to specify a single value without the parens, but it's not a high priority (and I don't know how to do that). Cheers, Viktor > > Best, > > Alan >