From mboxrd@z Thu Jan  1 00:00:00 1970
From: Viktor Rosenfeld <listuser36@gmail.com>
Subject: Re: [PATCH] Improve configurability of ox-koma-letter
Date: Mon, 22 Apr 2013 12:57:42 +0200
Message-ID: <20130422105742.GD7821@cartman>
References: <20130421175957.GA7821@cartman> <m2li8b6khn.fsf@polytechnique.org>
	<87ppxnkl4d.fsf@gmail.com> <m2k3nu7vz8.fsf@polytechnique.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:54448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <listuser36@gmail.com>) id 1UUERS-0002Du-5b
	for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 06:57:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <listuser36@gmail.com>) id 1UUERQ-0006q3-VK
	for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 06:57:50 -0400
Received: from mail-bk0-x234.google.com ([2a00:1450:4008:c01::234]:56314)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <listuser36@gmail.com>) id 1UUERQ-0006pt-OU
	for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 06:57:48 -0400
Received: by mail-bk0-f52.google.com with SMTP id it16so2532128bkc.39
	for <emacs-orgmode@gnu.org>; Mon, 22 Apr 2013 03:57:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <m2k3nu7vz8.fsf@polytechnique.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-orgmode@gnu.org

Hi Alan,

Alan Schmitt wrote:

> A couple notes about the patch:
> - Could you create it using "git format-patch"? This way we'll have
> more metadata in the commit.

I actually did that first and liked it more because then the patch was
split into more logical blocks (nine patches in total). However, I did
not add correct changelog entries to the commits. Should I resend the
individual patches nevertheless? I could add/change the commit message
manually in the email, I suppose.

> - I think there is an issue with the handling of signatures. I tried
> with an old letter that uses a LCO with a graphical signature in it, but
> it gets overridden upon export. Here is the generated TeX.
> 
> #+BEGIN_SRC latex
> \LoadLetterOption{InriaRennesFR}
> \setkomavar{signature}{\usekomavar{fromname}}
> #+END_SRC
> 

Have you tried clearing the signature?

#+BEGIN_SRC emacs-lisp
(setq org-koma-letter-signature nil)
#+END_SRC

Cheers,
Viktor

> 
> It seems to come from this part of the patch:
> 
> #+BEGIN_SRC emacs-lisp
> 	 (signature (plist-get info :signature)))
>      (concat
>       ;; Letter Class Option File
>       (when lco 
> 	(let ((lco-files (split-string lco " "))
> 	      (lco-def ""))
> 	  (dolist (lco-file lco-files lco-def)
> 	    (setq lco-def (format "%s\\LoadLetterOption{%s}\n" lco-def lco-file)))
> 	  lco-def))
>       ;; Define "From" data.
>       (when sender (format "\\setkomavar{fromname}{%s}\n" sender))
>       (when from-address (format "\\setkomavar{fromaddress}{%s}\n" from-address))
>       (when phone-number (format "\\setkomavar{fromphone}{%s}\n" phone-number))
>       (when email (format "\\setkomavar{fromemail}{%s}\n" email))
>       (when signature (format "\\setkomavar{signature}{%s}\n" signature))))
> #+END_SRC
> 
> If signature is set for some reason (and it seems to be by default),
> then it will override what is in the LCO. I have not found a way to
> set the options such that the signature from the LCO gets picked up.
> 
> Alan
>