emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Strey <mstrey@strey.biz>
To: emacs-orgmode@gnu.org
Subject: Re: [patch] ox-koma-letter
Date: Wed, 27 Feb 2013 11:51:02 +0100	[thread overview]
Message-ID: <20130227105102.GV24632@strey.biz> (raw)
In-Reply-To: <87mwuqg4ln.fsf@pank.iue.private>

On Tue, Feb 26, 2013 at 10:14:28PM +0100, Rasmus wrote:

[...]

> > Wouldn't it be better to use Markus Kohm's concept of letter class
> > options to set all the static stuff?
> 
> Potentially.  What do you mean by "letter class options"?  Are you
> referring to customized LCO files or do you refer to e.g. customized
> org-latex-classes?  

I mean customized LCO files.  For my former company I had made a letter
class for business letters based on scrlttr2.cls with two LCO files.
the first LCO file *company.lco* contained the general information about
the company (address, bank account, etc.).  A second LCO file
*my_name.lco* contained the personal information of (e-mail address,
name, phone extension).  With *my_name.lco* calling *company.lco* the
document class command for my letter finally was:

\documentclass[my_name]{our_company_letter_class}

With suitable setting of org-latex-classes not even the LCO feature
would be needed in ox-koma-letter.  However I would leave it there for
more flexibility.


[...]

> Even when using a dedicated LCO files and or org-latex-classes it
> might be appropriate to overwrite variables.  

Yes, I can imagine such cases.  My problem with the current
implementation was, that for instance, the phone number was preset in
org-latex-classes.  That urged me to customize this variable although
everything was already well defined in *my_name.lco*.  So, please take
care to preset such variables with nil, where nil shall have the meaning
of 'ignore this variable'.


> In any case I don't have a strong opinion on this issue and your
> approach also makes sense.

Maybe we should write a user guide *before* further implementation steps.


> >>   2. Added AFTER_CLOSING and AFTER_LETTER keywords for arbitrary code
> >>      after \closing{.} and \end{letter}, respectively.
> >>      [...]
> >>      b. Would it be better to have a dedicated, say, PS and ENCL rather
> >>         than the generic AFTER_CLOSING?
> > I would opt for dedicated variables.
> 
> Fine by be..  At the very least these should come in the order that
> they are specified in the document, I guess.  E.g. I should be able to
> place ENCL before PS in the output, if I so desire.

Mmmh ... never thought about this aspect.  I simply dictated the order
of CC, ENCL and PS in my implementation.  Thus your current
AFTER_CLOSING is the best solution, if you want to provide full
flexibility.

> For arbitrary code I find AFTER_CLOSING and AFTER_LETTER nice.
> E.g. for pdfpages inclusions.

Agreed.

Best regards
-- 
Michael Strey 
www.strey.biz

  reply	other threads:[~2013-02-27 10:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25 20:25 [patch] ox-koma-letter Rasmus
2013-02-26  9:50 ` Bastien
2013-02-26 11:53   ` Rasmus
2013-02-26 12:38 ` Michael Strey
2013-02-26 21:14   ` Rasmus
2013-02-27 10:51     ` Michael Strey [this message]
2013-02-27 12:13       ` Rasmus
2013-02-27 13:41         ` Sebastien Vauban
2013-02-27 16:48           ` Rasmus
2013-02-28 15:19         ` Michael Strey
2013-03-02 17:53           ` Rasmus
2013-03-01 13:17 ` Alan Schmitt
2013-03-02 10:26   ` Bastien
2013-03-02 15:50     ` Alan Schmitt
2013-03-02 18:12       ` Bastien
2013-03-02 17:54   ` Rasmus
2013-03-02 17:57   ` Rasmus
2013-03-02 19:21     ` Alan Schmitt
2013-03-02 21:58       ` Rasmus
2013-03-03 16:00         ` Alan Schmitt
2013-03-03 17:25           ` Nicolas Goaziou
2013-03-04  7:19             ` Alan Schmitt
2013-03-04  8:33               ` Nicolas Goaziou
2013-03-04  8:56                 ` Alan Schmitt
2013-03-04 10:38                   ` Rasmus
2013-03-04 20:38                     ` Nicolas Goaziou
2013-03-05  9:08                       ` Alan Schmitt
2013-03-05  9:52                         ` Nicolas Goaziou
2013-03-05 10:51                       ` Michael Strey
2013-03-05 12:23                         ` Rasmus
2013-03-05 13:09                           ` Michael Strey
2013-03-06  9:03                         ` Alan Schmitt
2013-03-06  9:09                           ` Nicolas Goaziou
2013-03-04 10:46               ` Michael Strey
2013-03-04 13:48                 ` Alan Schmitt
2013-03-04 21:20                 ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130227105102.GV24632@strey.biz \
    --to=mstrey@strey.biz \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).