From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toby Cubitt Subject: Re: [PATCH] Separate clocksum format for durations >= 1 day Date: Wed, 14 Nov 2012 17:20:14 +0100 Message-ID: <20121114162014.GA13397@c3po> References: <87zk2kyxml.fsf@gmail.com> Reply-To: Toby Cubitt Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([208.118.235.92]:58853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYfh5-0007Sv-SW for emacs-orgmode@gnu.org; Wed, 14 Nov 2012 11:20:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYfh1-0006zJ-2j for emacs-orgmode@gnu.org; Wed, 14 Nov 2012 11:20:02 -0500 Received: from starfish.geekisp.com ([216.168.135.166]:18642) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1TYfh0-0006z8-TV for emacs-orgmode@gnu.org; Wed, 14 Nov 2012 11:19:59 -0500 Content-Disposition: inline In-Reply-To: <87zk2kyxml.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org On Wed, Nov 14, 2012 at 05:09:38PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > I can easily allow org-time-clocksum-fractional-format to be a list of > > formats. But "1d 3.4h" doesn't seem very useful to me. Probably it should > > work a bit differently: format the time as a fractional quantity, using > > the largest time unit which will give a non-zero integer part. > > > > Does that sound reasonable? > > That's the idea, yes. Though, it will be the largest time unit _with > a format string_ which will give a non-zero integer part. Yes, that's what I meant. > > OK, but in this case I think the single-format-string option is still > > useful. It gives users a simpler way of customizing the format if they > > don't want to do anything fancy. > > If they don't want to do anything fancy, they use the default value, > whatever it may be. ;) I don't mind keeping the single format string > option anyway. I'll leave it in my patch. If you want to remove it for 8.0, it'll be a simple case of deleting some code. > > I'll post an updated patch when I get time to make the changes. > > Since it's for 8.0, there's no hurry. I'll wait for you to merge the two > patches and make subsequent changes. OK. Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: tsc25@cantab.net web: www.dr-qubit.org