From: Toby Cubitt <tsc25@cantab.net>
To: emacs-orgmode@gnu.org
Subject: Re: bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll
Date: Sat, 21 Apr 2012 21:34:06 +0200 [thread overview]
Message-ID: <20120421193406.GA1111@c3po.home> (raw)
In-Reply-To: <8762cuy5rw.fsf@altern.org>
On Fri, Apr 20, 2012 at 01:57:55PM +0200, Bastien wrote:
> Toby Cubitt <tsc25@cantab.net> writes:
>
> > On Mon, Apr 16, 2012 at 05:50:50AM +0300, Eli Zaretskii wrote:
> >> > Date: Sun, 15 Apr 2012 23:04:16 +0200
> >> > Cc: 11249@debbugs.gnu.org, emacs-orgmode@gnu.org
> >> > From: Toby Cubitt <toby-dated-1335733484.f898fc@dr-qubit.org>
> >> >
> >> > The obvious solution is for org-mode to use a face that doesn't enlarge
> >> > the characters.
> >>
> >> Another solution would be to enlarge the calendar window by one line.
> >
> > I've attached a patch that does exactly this. As expected, it fixes the
> > bug for me.
> >
> > As discussed previously, the alternative solution would be to change the
> > default face used to highlight the current date to something that doesn't
> > set the :bold attribute (which would probably mean introducing a separate
> > face for this, instead of reusing org-warning). But expanding the
> > calendar window is a more general solution, as it fixes the problem for
> > (almost) any face.
>
> I introduced a new face `org-date-selected' which is now the one in use
> in the calendar and which is not bold.
Thanks for the fix. I notice that the new face's dosctring still says
"Face for deadlines and TODO keywords", which needs changing.
Was there some reason to reject Eli's suggested fix of enlarging the
calendar window by 1 line? As it stands, if anyone customizes the new
org-date-selected face to be bold (the highlighted date *is* a little
less visible now), it will cause the same problem as before. And the fact
that it's caused by making the font bold is not at all obvious...at
least, it wasn't obvious to me! Eli's fix works more generally.
Anyway, since I now know how to patch things if I do decide I want a bold
font, it's not a big issue for me.
In the patch I posted, I also took the opportunity to set `cursor-type'
to nil when opening the calendar in `org-read-date'. The cursor obscures
one digit of the selected date, making that bit harder to read (as well
as looking ugly). Did you intend to reject this change too?
Toby
--
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain
email: tsc25@cantab.net
web: www.dr-qubit.org
next prev parent reply other threads:[~2012-04-21 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83zkaczq1v.fsf@gnu.org>
2012-04-15 21:04 ` bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll Toby Cubitt
2012-04-16 2:50 ` Eli Zaretskii
2012-04-16 13:41 ` Toby Cubitt
2012-04-20 11:57 ` Bastien
2012-04-21 19:34 ` Toby Cubitt [this message]
2012-04-22 6:46 ` Bastien
2012-04-22 10:05 ` Toby Cubitt
2012-04-25 21:30 ` Matt Lundin
2012-04-25 23:10 ` Matt Lundin
2012-04-26 8:59 ` Bastien
2012-04-26 13:19 ` Toby Cubitt
2012-04-26 13:43 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120421193406.GA1111@c3po.home \
--to=tsc25@cantab.net \
--cc=emacs-orgmode@gnu.org \
--cc=toby-dated-1336246473.8d5461@dr-qubit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).