From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Fix marker in no buffer error for task state change in an indirect buffer
Date: Sun, 11 Dec 2011 18:23:13 +0100 (CET) [thread overview]
Message-ID: <20111211172313.F136F13E90@myhost.localdomain> (raw)
In-Reply-To: 1321739047-11936-1-git-send-email-bernt@norang.ca
Patch 1050 (http://patchwork.newartisans.com/patch/1050/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C1321739047-11936-1-git-send-email-bernt%40norang.ca%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] Fix marker in no buffer error for task state change in an
> indirect buffer
> Date: Sun, 20 Nov 2011 02:44:07 -0000
> From: Bernt Hansen <bernt@norang.ca>
> X-Patchwork-Id: 1050
> Message-Id: <1321739047-11936-1-git-send-email-bernt@norang.ca>
> To: emacs-orgmode@gnu.org
> Cc: Bernt Hansen <bernt@norang.ca>, carsten.dominik@gmail.com
>
> * lisp/org-clock.el (org-clock-out-if-current): Fix marker in no buffer error
> for task state change in an indirect buffer
>
> org-clock-out-when-current was enhanced in 098cf35 (Clock: Clock out
> when done also in indirect buffers, 2009-03-23) to handle indirect
> buffers.
>
> This enhancement uses (buffer-base-buffer (org-clocking-buffer)) but
> when not clocking (org-clocking-buffer) returns nil - so
> buffer-base-buffer returns the base buffer of the current buffer which
> is never nil. This leads to marker in no buffer errors trying to stop
> the clock when it is not running.
>
> Now we explicitly check up front that the clock is running before
> any other conditions that lead to stopping the clock.
>
> ---
> cc:ing Carsten since this is his code
>
> Hi Dave,
>
> After much difficulty I was able to reproduce this problem. It would
> have been helpful to include basic information about what triggers the
> bug for you.
>
> - clock is not running
> - You are working in an indirect buffer
> - You change a todo state keyword to DONE
>
> This works fine for me when not in an indirect buffer.
>
> The git commit you have referenced in this report is not part of the org
> repository which also made me think you had local changes that affected
> this issue since I couldn't reproduce it for the first 20 minutes of
> looking at this issue.
>
> Please try this patch and report back if it works or not.
>
> Thanks,
> Bernt
>
>
> lisp/org-clock.el | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 5dbe4dc..9107400 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -1696,7 +1696,8 @@ from the `before-change-functions' in the current buffer."
> "Clock out if the current entry contains the running clock.
> This is used to stop the clock after a TODO entry is marked DONE,
> and is only done if the variable `org-clock-out-when-done' is not nil."
> - (when (and org-clock-out-when-done
> + (when (and (org-clocking-p)
> + org-clock-out-when-done
> (or (and (eq t org-clock-out-when-done)
> (member state org-done-keywords))
> (and (listp org-clock-out-when-done)
>
next prev parent reply other threads:[~2011-12-11 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 18:08 Bug: org-clock-out-if-current => "marker does not point anywhere" [7.7 (release_7.7.397.g5adafd)] Dave Abrahams
2011-11-19 21:44 ` [PATCH] Fix marker in no buffer error for task state change in an indirect buffer Bernt Hansen
2011-12-11 17:23 ` Bastien Guerry [this message]
2011-12-11 17:23 ` Bastien
2011-11-23 4:49 ` [PATCH] Bug: org-clock-out-if-current => "marker does not point anywhere" [7.7 (release_7.7.397.g5adafd)] Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111211172313.F136F13E90@myhost.localdomain \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).