From: Anders Waldenborg <anders@0x63.nu>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Nicolas Goaziou <n.goaziou@gmail.com>,
Org mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: PATCH Make org-open-at-point only ask once
Date: Thu, 6 Oct 2011 10:43:50 +0200 [thread overview]
Message-ID: <20111006084350.GD26104@0x63.nu> (raw)
In-Reply-To: <D0086051-D308-4DB3-8105-EE316C3B8CF6@gmail.com>
On Thu, Oct 06, 2011 at 10:00:38AM +0200, Carsten Dominik wrote:
> Hi Anders, Nicolas
>
> I am wondering what the status of this patch is. There was a discussion, but I am not sure about the conclusion...
Carsten,
I think that the simple patch still is valid, I'm including it again
below.
The discussion was about my more intrusive alternative patch, and how
links change their meaning depending on if the buffer is narrowed or
not. I did start to hack up a alternative link resolver as a proof of
concept to be able to better understand how links should work in case
there are multiple targets, but unfortunately I got busy with other
things.
anders
--
commit 54702f063ae2df48dec7f9feb80859a6b64002a4
Author: Anders Waldenborg <anders@0x63.nu>
Date: Sat Aug 27 21:18:46 2011 +0200
Make org-open-at-point only ask once whether new header should be created.
When following "thisfile" links org-open-at-point is kind enough to
retry org-link-search again after widening the buffer it can't be
found. However org-link-search also asks the question "No match -
create this as a new heading? (y or n)" when target can't be
found. This means that the question is asked twice when following a
nonexistent link and answering no.
This is fixed by setting org-link-search-inhibit-query in first try,
so only second invocation asks the question.
diff --git a/lisp/org.el b/lisp/org.el
index d63b854..781de88 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9537,7 +9537,8 @@ application the system uses for this file type."
((equal arg '(16)) ''org-occur)
(t nil))
,pos)))
- (condition-case nil (eval cmd)
+ (condition-case nil (let ((org-link-search-inhibit-query t))
+ (eval cmd))
(error (progn (widen) (eval cmd))))))
(t
next prev parent reply other threads:[~2011-10-06 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 20:05 PATCH Make org-open-at-point only ask once Anders Waldenborg
2011-08-29 7:14 ` Nicolas Goaziou
2011-08-29 9:21 ` Anders Waldenborg
2011-08-29 9:36 ` Nicolas Goaziou
2011-08-29 10:53 ` Anders Waldenborg
2011-08-29 11:25 ` Nicolas Goaziou
2011-10-06 8:00 ` Carsten Dominik
2011-10-06 8:43 ` Anders Waldenborg [this message]
2011-10-06 8:54 ` Carsten Dominik
2011-10-06 9:51 ` Anders Waldenborg
2011-10-06 9:57 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006084350.GD26104@0x63.nu \
--to=anders@0x63.nu \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).