emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Anders Waldenborg <anders@0x63.nu>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: PATCH Make org-open-at-point only ask once
Date: Mon, 29 Aug 2011 11:21:46 +0200	[thread overview]
Message-ID: <20110829092146.GT5700@0x63.nu> (raw)
In-Reply-To: <87liuclmey.fsf@gmail.com>

On Mon, Aug 29, 2011 at 09:14:13AM +0200, Nicolas Goaziou wrote:
> Yes, imposing widening to the user is intrusive. Moreover, I think you
> cannot avoid to call org-link-search twice (once it has failed): the
> point is to do a local search and then a global one.

Yes, "local then global" search makes sense (I especially like how the
infobrowser pops out to a global search with an extra ^S after failure).

But for org links, I'm not 100% sure - consider this org-file:

* Notes
* Some topic
[[Notes]]
** Notes

If buffer is widen, the link goes to the toplevel header, but if I
narrow to "Some topic" the link suddenly starts going to the subheader.

So the links meaning changes depending on if the buffer is narrowed or
not.

I'm not sure it really is a problem, I just want to make sure it is taken
into consideration.

> 
> Though, the macro idea is interesting, as I can see at least one other
> place where it might be useful. So, what about changing the macro to:
> 
> 1. If current buffer is narrowed, execute body with the current
>    restriction. If it fails (silently), re-execute body with a widened
>    buffer. Restore default narrowing.

Fails means that it throws error? Or any exception?

> 
> 2. If the buffer has no narrowing in effect, just execute body.
> 
> Also:

Thanks for the review, I'll look into it soon.

 anders

  reply	other threads:[~2011-08-29  9:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28 20:05 PATCH Make org-open-at-point only ask once Anders Waldenborg
2011-08-29  7:14 ` Nicolas Goaziou
2011-08-29  9:21   ` Anders Waldenborg [this message]
2011-08-29  9:36     ` Nicolas Goaziou
2011-08-29 10:53       ` Anders Waldenborg
2011-08-29 11:25         ` Nicolas Goaziou
2011-10-06  8:00 ` Carsten Dominik
2011-10-06  8:43   ` Anders Waldenborg
2011-10-06  8:54     ` Carsten Dominik
2011-10-06  9:51       ` Anders Waldenborg
2011-10-06  9:57         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829092146.GT5700@0x63.nu \
    --to=anders@0x63.nu \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).