From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Re: [PATCH] fix a bug in org-open-at-point
Date: Sat, 26 Feb 2011 18:14:57 +0100 (CET) [thread overview]
Message-ID: <20110226171457.245571E6E2@myhost.localdomain> (raw)
In-Reply-To: 8739nk1jmd.fsf@gmail.com
Patch 624 (http://patchwork.newartisans.com/patch/624/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C8739nk1jmd.fsf%40gmail.com%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: [PATCH] fix a bug in org-open-at-point
> Date: Sat, 19 Feb 2011 14:03:38 -0000
> From: Nicolas Goaziou <n.goaziou@gmail.com>
> X-Patchwork-Id: 624
> Message-Id: <8739nk1jmd.fsf@gmail.com>
> To: emacs-orgmode@gnu.org
>
> My bad, wrong manipulation. Here is the patch.
>
> To reproduce the error, you can type the following in a fresh Org
> #+begin_src org
> target some text <<<target>>> another text target
> #+end_src
>
> Using C-c C-o on any of the two links will return an error.
> Regards,
>
>
> >From f7738f3e9239fc4fddccc7850dad7a0936087a58 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <n.goaziou@gmail.com>
> Date: Sat, 19 Feb 2011 09:37:48 +0100
> Subject: [PATCH] Fix bug with link to radio target at beginning or end of buffer
>
> * lisp/org.el (org-open-at-point): if a link to a radio target is the
> first, (resp. the last), element of a buffer, function cannot find
> the property change required to get its boundaries, and
> `buffer-substring' is called with an invalid nil argument.
> ---
> lisp/org.el | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index b92186a..bfe9296 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9214,8 +9214,10 @@ application the system uses for this file type."
> pos (if (get-text-property (1+ (point)) 'org-linked-text)
> (1+ (point)) (point))
> path (buffer-substring
> - (previous-single-property-change pos 'org-linked-text)
> - (next-single-property-change pos 'org-linked-text)))
> + (or (previous-single-property-change pos 'org-linked-text)
> + (point-min))
> + (or (next-single-property-change pos 'org-linked-text)
> + (point-max))))
> (throw 'match t))
>
> (save-excursion
> --
> 1.7.4.1
>
>
prev parent reply other threads:[~2011-02-26 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 8:52 [PATCH] fix a bug in org-open-at-point Nicolas
2011-02-19 9:03 ` Nicolas
2011-02-26 17:14 ` Bastien Guerry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110226171457.245571E6E2@myhost.localdomain \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).