emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Optimize org-habit-parse-todo
Date: Tue, 25 Jan 2011 22:59:06 +0100 (CET)	[thread overview]
Message-ID: <20110125215906.8E76F8BAD96@carsten-dominiks-macbook-pro.local> (raw)
In-Reply-To: 87sjwgn42k.fsf@fastmail.fm

Patch 558 (http://patchwork.newartisans.com/patch/558/) is now "Accepted".

Maintainer comment: No comment

This relates to the following submission:

http://mid.gmane.org/%3C87sjwgn42k.fsf%40fastmail.fm%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Optimize org-habit-parse-todo
> Date: Wed, 26 Jan 2011 01:03:47 -0000
> From: Matt Lundin <mdl@imapmail.org>
> X-Patchwork-Id: 558
> Message-Id: <87sjwgn42k.fsf@fastmail.fm>
> To: Carsten Dominik <carsten.dominik@gmail.com>
> Cc: Org Mode <emacs-orgmode@gnu.org>
> 
> * lisp/org-habit.el: (org-habit-parse-todo) Don't parse more days than
>   needed.
> 
> When constructing a consistency graph, org-habit now stops searching
> for timestamps when the number of matches exceeds the span of time
> displayed in the graph. This can lead to a significant speedup in
> agenda construction, especially for entries with many logbook entries.
> Previously, org-habit would parse all logbook timestamps, even if they
> numbered in the hundreds.
> 
> ---
> lisp/org-habit.el |   16 ++++++++++++----
>  1 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/lisp/org-habit.el b/lisp/org-habit.el
> index b174a1f..5d2514a 100644
> --- a/lisp/org-habit.el
> +++ b/lisp/org-habit.el
> @@ -170,10 +170,18 @@ This list represents a \"habit\" for the rest of this module."
>  		   habit-entry scheduled-repeat))
>  	(setq deadline (+ scheduled (- dr-days sr-days))))
>        (org-back-to-heading t)
> -      (while (re-search-forward "- State \"DONE\".*\\[\\([^]]+\\)\\]" end t)
> -	(push (time-to-days
> -	       (org-time-string-to-time (match-string-no-properties 1)))
> -	      closed-dates))
> +      (let* ((maxdays (+ org-habit-preceding-days org-habit-following-days))
> +	     (reversed org-log-states-order-reversed)
> +	     (search (if reversed 're-search-forward 're-search-backward))
> +	     (limit (if reversed end (point)))
> +	     (count 0))
> +	(unless reversed (goto-char end))
> +	(while (and (< count maxdays)
> +		    (funcall search "- State \"DONE\".*\\[\\([^]]+\\)\\]" limit t))
> +	  (push (time-to-days
> +		 (org-time-string-to-time (match-string-no-properties 1)))
> +		closed-dates)
> +	  (setq count (1+ count))))
>        (list scheduled sr-days deadline dr-days closed-dates))))
>  
>  (defsubst org-habit-scheduled (habit)
> 

next prev parent reply	other threads:[~2011-01-29 22:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 12:39 [PATCH] Optimize org-habit-parse-todo Matt Lundin
2011-01-25  6:01 ` Carsten Dominik
2011-01-25  6:21   ` Carsten Dominik
2011-01-25 20:03     ` Matt Lundin
2011-01-25 21:59       ` Carsten Dominik [this message]
2011-01-25 21:59       ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110125215906.8E76F8BAD96@carsten-dominiks-macbook-pro.local \
    --to=cdominik@newartisans.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).