emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Re: [bug] org-store-link on gnus message fails
Date: Thu, 13 Jan 2011 12:53:01 +0100 (CET)	[thread overview]
Message-ID: <20110113115301.68C0B87448A@ehef110.hef.ru.nl> (raw)
In-Reply-To: 87bp3moyua.fsf@member.fsf.org

Patch 533 (http://patchwork.newartisans.com/patch/533/) is now "Accepted".

Maintainer comment: No comment

This relates to the following submission:

http://mid.gmane.org/%3C87bp3moyua.fsf%40member.fsf.org%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: [bug] org-store-link on gnus message fails
> Date: Wed, 12 Jan 2011 21:45:17 -0000
> From: Tassilo Horn <tassilo@member.fsf.org>
> X-Patchwork-Id: 533
> Message-Id: <87bp3moyua.fsf@member.fsf.org>
> To: emacs-orgmode@gnu.org
> 
> Hi Eric,
> 
> this patch should do the trick.  I think the issue was a malformed Date:
> header that couldn't be converted to a timestamp.
> 
> --8<---------------cut here---------------start------------->8---
> --8<---------------cut here---------------end--------------->8---
> 
> Bye,
> Tassilo
> 
> 
> diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
> index 32641bf..ae5dc52 100644
> --- a/lisp/org-gnus.el
> +++ b/lisp/org-gnus.el
> @@ -152,11 +152,16 @@ If `org-store-link' was called with a prefix arg the meaning of
>  	   (from (mail-header-from header))
>  	   (message-id (org-remove-angle-brackets (mail-header-id header)))
>  	   (date (org-trim (mail-header-date header)))
> -	   (date-ts (and date (format-time-string
> -			       (org-time-stamp-format t) (date-to-time date))))
> -	   (date-ts-ia (and date (format-time-string
> -				  (org-time-stamp-format t t)
> -				  (date-to-time date))))
> +	   (date-ts (and date
> +			 (condition-case nil
> +			     (format-time-string
> +			      (org-time-stamp-format t)
> +			      (date-to-time date)))))
> +	   (date-ts-ia (and date
> +			    (condition-case nil
> +				(format-time-string
> +				 (org-time-stamp-format t t)
> +				 (date-to-time date)))))
>  	   (subject (copy-sequence (mail-header-subject header)))
>  	   (to (cdr (assq 'To (mail-header-extra header))))
>  	   newsgroups x-no-archive desc link)
> 

next prev parent reply	other threads:[~2011-01-13 11:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 13:58 [bug] org-store-link on gnus message fails Eric S Fraga
2011-01-12 16:36 ` Tassilo Horn
2011-01-12 16:45 ` Tassilo Horn
2011-01-12 20:23   ` Eric S Fraga
2011-01-13  8:38     ` Sébastien Vauban
2011-01-14  8:48       ` Eric S Fraga
2011-01-13 11:53   ` Carsten Dominik [this message]
2011-01-13 13:38     ` [Accepted] " Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110113115301.68C0B87448A@ehef110.hef.ru.nl \
    --to=cdominik@newartisans.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).