emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-agenda: return multiple results when sexp return a string with "; "
@ 2010-11-03 17:32 Julien Danjou
  2010-11-04 12:06 ` [Accepted] " Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Danjou @ 2010-11-03 17:32 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Julien Danjou

When evaluating my %%(org-calendar-holidays) on October 31st, I got a
line like:

"Halloween; Daylight Saving Time Ends 3:00am (CEST)"

And it displays in calendar:
3:00 .... Halloween; Daylight Saving Time Ends (CEST)

This is wrong since Halloween is all day, not only at 3:00.

Splitting results on "; " allows to have an independant entry on each
event and displays things correctly.

Signed-off-by: Julien Danjou <julien@danjou.info>
---
 lisp/org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index cb99712..effe9b2 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15025,7 +15025,7 @@ D may be an absolute day number, or a calendar-type list (month day year)."
 			      (org-current-line)
 			      (buffer-file-name) sexp)
                      (sleep-for 2))))))
-    (cond ((stringp result) result)
+    (cond ((stringp result) (split-string result "; "))
 	  ((and (consp result)
 		(not (consp (cdr result)))
 		(stringp (cdr result))) (cdr result))
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Accepted] org-agenda: return multiple results when sexp return a string with "; "
  2010-11-03 17:32 [PATCH] org-agenda: return multiple results when sexp return a string with "; " Julien Danjou
@ 2010-11-04 12:06 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-11-04 12:06 UTC (permalink / raw)
  To: emacs-orgmode

Patch 358 (http://patchwork.newartisans.com/patch/358/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C1288805538-13133-1-git-send-email-julien%40danjou.info%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] org-agenda: return multiple results when sexp return a
> 	string with "; "
> Date: Wed, 03 Nov 2010 22:32:18 -0000
> From: Julien Danjou <julien@danjou.info>
> X-Patchwork-Id: 358
> Message-Id: <1288805538-13133-1-git-send-email-julien@danjou.info>
> To: emacs-orgmode@gnu.org
> Cc: Julien Danjou <julien@danjou.info>
> 
> When evaluating my %%(org-calendar-holidays) on October 31st, I got a
> line like:
> 
> "Halloween; Daylight Saving Time Ends 3:00am (CEST)"
> 
> And it displays in calendar:
> 3:00 .... Halloween; Daylight Saving Time Ends (CEST)
> 
> This is wrong since Halloween is all day, not only at 3:00.
> 
> Splitting results on "; " allows to have an independant entry on each
> event and displays things correctly.
> 
> Signed-off-by: Julien Danjou <julien@danjou.info>
> 
> ---
> lisp/org.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index cb99712..effe9b2 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -15025,7 +15025,7 @@ D may be an absolute day number, or a calendar-type list (month day year)."
>  			      (org-current-line)
>  			      (buffer-file-name) sexp)
>                       (sleep-for 2))))))
> -    (cond ((stringp result) result)
> +    (cond ((stringp result) (split-string result "; "))
>  	  ((and (consp result)
>  		(not (consp (cdr result)))
>  		(stringp (cdr result))) (cdr result))
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-04 12:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-03 17:32 [PATCH] org-agenda: return multiple results when sexp return a string with "; " Julien Danjou
2010-11-04 12:06 ` [Accepted] " Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).