emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] inside table, delete-backward-char must not insert spaces when overwrite mode is on
Date: Sun,  5 Sep 2010 22:29:22 +0200 (CEST)	[thread overview]
Message-ID: <20100905202922.A5D5E537CF@myhost.localdomain> (raw)
In-Reply-To: 201008271956.43528.Stromeko@stromeko.net

Patch 245 (http://patchwork.newartisans.com/patch/245/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C201008271956.43528.Stromeko%40stromeko.net%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] inside table,
> 	delete-backward-char must not insert spaces when overwrite mode is on
> Date: Fri, 27 Aug 2010 22:56:43 -0000
> From: Achim Gratz <Stromeko@stromeko.net>
> X-Patchwork-Id: 245
> Message-Id: <201008271956.43528.Stromeko@stromeko.net>
> To: emacs-orgmode@gnu.org
> 
> * lisp/org.el (org-delete-backward-char): check for nil overwrite-mode before inserting 
> spaces.
> 
> TINYCHANGE
> 
> There's probably a different/better way to do this, but this seemed the least intrusive.
> This patch is in the public domain.
> 
> ---
> lisp/org.el |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index bc62633..41f35d4 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16597,9 +16597,11 @@ because, in this case the deletion might narrow the column."
>  	    (noalign (looking-at "[^|\n\r]*  |"))
>  	    (c org-table-may-need-update))
>  	(backward-delete-char N)
> -	(skip-chars-forward "^|")
> -	(insert " ")
> -	(goto-char (1- pos))
> +	(if (not overwrite-mode)
> +	    (progn
> +	      (skip-chars-forward "^|")
> +	      (insert " ")
> +	      (goto-char (1- pos))))
>  	;; noalign: if there were two spaces at the end, this field
>  	;; does not determine the width of the column.
>  	(if noalign (setq org-table-may-need-update c)))
> 

     prev parent reply	other threads:[~2010-09-05 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 17:56 [PATCH] inside table, delete-backward-char must not insert spaces when overwrite mode is on Achim Gratz
2010-09-03  0:27 ` Bastien
2010-09-03 19:42   ` Achim Gratz
2010-09-05 18:00     ` Bastien
2010-09-05 20:29       ` Bastien
2010-09-05 20:29 ` Bastien Guerry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100905202922.A5D5E537CF@myhost.localdomain \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).