emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Re: html-export mangels mailto: links
Date: Thu,  2 Sep 2010 17:33:21 +0200 (CEST)	[thread overview]
Message-ID: <20100902153321.B350445BB3@myhost.localdomain> (raw)
In-Reply-To: 87iq2o3b5s.fsf@noorul.maa.corp.collab.net

Patch 251 (http://patchwork.newartisans.com/patch/251/) is now "Accepted".

Maintainer comment: Applied a slightly modified version: better handling of absolute filenames.

This relates to the following submission:

http://mid.gmane.org/%3C87iq2o3b5s.fsf%40noorul.maa.corp.collab.net%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: html-export mangels mailto: links
> Date: Thu, 02 Sep 2010 11:35:43 -0000
> From: Noorul Islam <noorul@noorul.com>
> X-Patchwork-Id: 251
> Message-Id: <87iq2o3b5s.fsf@noorul.maa.corp.collab.net>
> To: Achim Gratz <Stromeko@nexgo.de>
> Cc: emacs-orgmode@gnu.org
> 
> Achim Gratz <Stromeko@nexgo.de> writes:
> 
> > HTML export removes the "mailto:" from a link, which will then be
> > interpreted as a local link by the browser.
> >
> > For an example, see the link to this mailing list in
> > ORGWEBPAGE/index.org and the corresponding HTML export on orgmode-org
> > (or just the local file).
> >
> 
> org-html.el : Fix exporting file, mailto, news and ftp protocols.
> 
> * lisp/org-html.el (org-html-make-link): (expand-file-name
> ) removes one "/" from "///path-to-file", so add one. Anything other
> than 'file' type should be exported along with the type.
> 
> TINYCHANGE
> 
> Thanks and Regards
> Noorul
> 
> 
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index 099b2e3..4430768 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -720,7 +720,7 @@ MAY-INLINE-P allows inlining it as an image."
>  			   ;;Substitute just if original path was absolute.
>  			   ;;(Otherwise path must remain relative)
>  			   (if (file-name-absolute-p path)
> -			      (expand-file-name path)
> +			      (concat "/" (expand-file-name path))
>  			      path)))
>  		     ((string= type "")
>  			(list nil path))
> @@ -756,8 +756,7 @@ MAY-INLINE-P allows inlining it as an image."
>  	 (setq thefile
>  	    (let
>  	       ((str (org-export-html-format-href thefile)))
> -	      (if (and type (not (string= "file" type))
> -		       (org-string-match-p "^//" str))
> +	      (if (and type (not (string= "file" type)))
>  		  (concat type ":" str)
>  		  str)))
>  
> 

  reply	other threads:[~2010-09-02 15:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 20:26 [Bug] html-export mangels mailto: links Achim Gratz
2010-09-02  6:35 ` [PATCH] " Noorul Islam K M
2010-09-02 15:33   ` Bastien Guerry [this message]
2010-09-02 15:35   ` Bastien
2010-09-12 18:29     ` Achim Gratz
2010-09-12 19:02       ` David Maus
2010-09-12 19:23         ` Achim Gratz
2010-09-12 19:29           ` Eric S Fraga
2010-09-12 19:36             ` Achim Gratz
2010-09-13  1:24               ` Nick Dokos
2010-09-13  4:56                 ` Achim Gratz
2010-09-13 18:34                   ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100902153321.B350445BB3@myhost.localdomain \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).