emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Adam Spiers <orgmode@adamspiers.org>
To: emacs-orgmode@gnu.org
Subject: Re: Re: org-show-effort ideas
Date: Wed, 4 Nov 2009 00:26:08 +0000	[thread overview]
Message-ID: <20091104002608.GH32187@atlantic.linksys.moosehall> (raw)
In-Reply-To: <87aaz37jqz.fsf@in-ulm.de>

Benjamin Andresen (benny@in-ulm.de) wrote:
> Adam Spiers <orgmode@adamspiers.org> writes:
> 
> > I definitely did try it, and I just did another 'git pull' and tried
> > again, and I still don't see it, so I guess we're talking about
> > different things ;-)
> >
> > To clarify, I'm referring to showing effort via a single keystroke
> > when on a todo line in the *Org Agenda* buffer.  Currently, when I hit
> > "e" on a todo which has an existing "Effort" property value set, my
> > minibuffer prompt shows "Value: ".  The same applies with C-c C-x e in
> > a normal .org file buffer.
> 
> When I press 'e' in an agenda on an item that has the Effort property
> value set, I get a minibuffer prompt that shows "Value [5]: " when the
> Effort value is 5.
> 
> This is with a git version from Sunday morning.
> 
> Check the source of the function org-set-effort, it will show you that
> it concats "[" cur "]", where cur is the current Effort prop value.

Thanks for the pointer - it seems that the "[" cur "]" is only
included when

  (org-property-get-allowed-values nil prop 'table)

is nil - and in my case I have a global Effort_ALL property set which
means that this is never the case.  So I think this is a bug which can
be trivially fixed by assigning the prompt string in the let* variable
list, and then using it in both invocations of org-completing-read.

next prev parent reply	other threads:[~2009-11-04  0:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 13:49 org-show-effort ideas Adam Spiers
2009-11-03  6:47 ` Carsten Dominik
2009-11-03 12:11   ` Adam Spiers
2009-11-03 14:42     ` Benjamin Andresen
2009-11-04  0:26       ` Adam Spiers [this message]
2009-11-04 13:19         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104002608.GH32187@atlantic.linksys.moosehall \
    --to=orgmode@adamspiers.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).