emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Friedrich Delgado Friedrichs <friedel@nomaden.org>
To: emacs-orgmode@gnu.org
Subject: Re: org-infojs-handle-options fails when :infojs-opt is not  in exp-list
Date: Thu, 8 Jan 2009 15:12:20 +0100	[thread overview]
Message-ID: <20090108141220.GA5649@taupan.ath.cx> (raw)
In-Reply-To: <20081223111440.GA25702@taupan.ath.cx>

Hi.

A while ago I had this problem:
org-infojs-handle-options: Wrong type argument: stringp, nil

I wonder if my patch ever reached the mailing list, or if it
was overlooked because it was too close to christmas:

Friedrich Delgado Friedrichs schrieb:
> >From 0fef25f56c837ae9f434449c6f30268e0474f7ab Mon Sep 17 00:00:00 2001
> From: Friedrich Delgado Friedrichs <delgado@dfn-cert.de>
> Date: Tue, 23 Dec 2008 12:10:42 +0100
> Subject: [PATCH] fix string-match against nil when no in-file options are set for jsinfo
> 
> ---
>  lisp/org-jsinfo.el |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-jsinfo.el b/lisp/org-jsinfo.el
> index 8f2d7e8..19faa9e 100644
> --- a/lisp/org-jsinfo.el
> +++ b/lisp/org-jsinfo.el
> @@ -140,7 +140,8 @@ Option settings will replace the %MANAGER-OPTIONS cookie."
>              default (cdr (assoc opt org-infojs-options)))
>        (and (symbolp default) (not (memq default '(t nil)))
>             (setq default (plist-get exp-plist default)))
> -      (if (string-match (format " %s:\\(\\S-+\\)" opt) v)
> +      (if (and v
> +               (string-match (format " %s:\\(\\S-+\\)" opt) v))
>            (setq val (match-string 1 v))
>          (setq val default))
>        (cond
> -- 
> 1.6.0.2.526.g5c283.dirty
---Zitatende---

-- 
        Friedrich Delgado Friedrichs <friedel@nomaden.org>
Laziness led to the invention of the most useful tools.

  reply	other threads:[~2009-01-08 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-23 10:47 Friedrich Delgado Friedrichs
2008-12-23 10:56 ` Friedrich Delgado Friedrichs
2008-12-23 11:14   ` Friedrich Delgado Friedrichs
2009-01-08 14:12     ` Friedrich Delgado Friedrichs [this message]
2009-01-08 14:36       ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108141220.GA5649@taupan.ath.cx \
    --to=friedel@nomaden.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: org-infojs-handle-options fails when :infojs-opt is not  in exp-list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).