From mboxrd@z Thu Jan 1 00:00:00 1970 From: James TD Smith Subject: Re: Incompatible change in latest push Date: Thu, 16 Oct 2008 11:02:57 +0100 Message-ID: <20081016100257.GA19032@nyarlathotep.internal.mohorovi.cc> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqPh9-00084a-6q for emacs-orgmode@gnu.org; Thu, 16 Oct 2008 06:03:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqPh7-00084G-K0 for emacs-orgmode@gnu.org; Thu, 16 Oct 2008 06:03:02 -0400 Received: from [199.232.76.173] (port=34532 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqPh7-00084B-EV for emacs-orgmode@gnu.org; Thu, 16 Oct 2008 06:03:01 -0400 Received: from 81-86-40-42.dsl.pipex.com ([81.86.40.42]:56857 helo=yog-sothoth.mohorovi.cc) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqPh6-0004li-V5 for emacs-orgmode@gnu.org; Thu, 16 Oct 2008 06:03:01 -0400 Received: from nyarlathotep.internal.mohorovi.cc (Debian-exim@nyarlathotep.internal.mohorovi.cc [10.0.0.5]) by yog-sothoth.mohorovi.cc (8.14.2/8.14.2) with ESMTP id m9GA2vGq085512 for ; Thu, 16 Oct 2008 11:02:57 +0100 (BST) (envelope-from ahktenzero@mohorovi.cc) Received: from ahktenzero by nyarlathotep.internal.mohorovi.cc with local (Exim 4.69) (envelope-from ) id 1KqPh3-0007Mt-3x for emacs-orgmode@gnu.org; Thu, 16 Oct 2008 11:02:57 +0100 Content-Disposition: inline In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Carsten, On 2008-10-16 06:55:02(+0200), Carsten Dominik wrote: > Hi, > > after a request, I just added a new variable > `org-log-state-notes-insert-after-drawers' with default nil. > This means that state change notes are now by default > inserted again *before* any drawers. This was the > original behaviour, which changed temporarily in version 6.08. I'm trying to figure out why anyone would want this behaviour. I first noticed it when the clock and properties drawers in some of my org entries seemed to disappear. After working out what was going on I decided it was a bug and wrote a patch to fix it. It makes no sense to me for the drawers in an entry to be swallowed up by state change notes. The drawers are not part of the entry, not the note, and should remain outside of the note. While having the drawers in the notes does not stop org from finding them, it does mean that you can't tell at a glance if an entry has clocked times or properties set as the relevant drawers will be hidden in one of the notes and not visible when the entry is first opened. For example, say you have a task as below: ,---- | * TODO Test | SCHEDULED: <2008-10-16 Wed +1d> | :PROPERTIES: | :LOGGING: lognoterepeat | :EFFORT: 2:00 | :OtherProperty: fish | :END: `---- When the entry is initially opened it appear as below: ,---- | * TODO Test | SCHEDULED: <2008-10-16 Wed +1d> | :PROPERTIES:... `---- If filing notes before drawers is enabled, the first time this is marked done the properties drawer will be included in the note, so the next time the user looks at it they will see this: ,---- | * TODO Test | SCHEDULED: <2008-10-17 Wed +1d> | - State "DONE" [2008-10-16 Thu 10:45]... `---- I imagine new org users will find it confusing when adding a note to an entry makes their drawers appear to vanish. It confused me and I've been using org for quite a while. I have no problem with keeping this a configurable option so anyone who wants the old behaviour can have it, but I think the default should be t. James -- |---|