From mboxrd@z Thu Jan 1 00:00:00 1970 From: James TD Smith Subject: Re: [PATCH 5/5] clipboard handling in remember templats Date: Wed, 9 Apr 2008 18:35:41 +0100 Message-ID: <20080409173541.GB57149@yog-sothoth.mohorovi.cc> References: <20080316162417.23004.16993.stgit@nyarlathotep.internal> <20080316163020.23004.90078.stgit@nyarlathotep.internal> <4477ED15-3E57-4A1F-93C0-B43BFAA5749E@science.uva.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JjebN-0004k6-A5 for emacs-orgmode@gnu.org; Wed, 09 Apr 2008 14:00:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JjebI-0004iL-R1 for emacs-orgmode@gnu.org; Wed, 09 Apr 2008 14:00:53 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JjebI-0004iC-NC for emacs-orgmode@gnu.org; Wed, 09 Apr 2008 14:00:48 -0400 Received: from 81-86-40-42.dsl.pipex.com ([81.86.40.42] helo=yog-sothoth.mohorovi.cc) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jjeaw-0000Y3-VZ for emacs-orgmode@gnu.org; Wed, 09 Apr 2008 14:00:48 -0400 Content-Disposition: inline In-Reply-To: <4477ED15-3E57-4A1F-93C0-B43BFAA5749E@science.uva.nl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org On 2008-04-09 17:32:22(+0200), Carsten Dominik wrote: > Hi James, > > I am going to accept this patch, but I do have a question about it: > > On Mar 16, 2008, at 5:31 PM, James TD Smith wrote: > > >From: James TD Smith > > > >org.el | 56 +++++++++++++++++++++++++++++++++++++++++--------------- > >1 files changed, 41 insertions(+), 15 deletions(-) > > [...] > > > (cond > > ((org-in-regexp org-bracket-link-regexp 1) > > ;; We do have a link at point, and we are going to edit it. > >@@ -12579,7 +12583,7 @@ link description." > > (setq link (org-make-link > > "file:" (match-string 1 (expand-file-name file))))) > > (t (setq link (org-make-link "file:" file)))))) > >- (t > >+ ((not link) > > ;; Read link, with completion for stored links. > > If you set it up like this, `link' will be overwritten be any link found at point. > Is you intention not to make the new argument link-location *overrule* anything > that might be at point? No, it should override any links at point. > So maybe the first alternative in the cond should be just (link), to bypass any parsing.... Yes. James