emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Maxim Nikulin <manikulin@gmail.com>
To: 12972@debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#12972: [PATCH] Avoid regression in mailcap-view-file similar to Bug#44824
Date: Fri, 2 Jul 2021 19:21:55 +0700	[thread overview]
Message-ID: <1ddf1c46-0a28-4a2d-cc40-094ff74ee0ac@gmail.com> (raw)
In-Reply-To: <835yxtlw14.fsf__2546.8955327355$1625164803$gmane$org@gnu.org>

On 02/07/2021 01:38, Eli Zaretskii wrote:
>> From: Maxim Nikulin Date: Fri, 2 Jul 2021 00:01:59 +0700
>>
>> --- a/lisp/net/mailcap.el
>> +++ b/lisp/net/mailcap.el
>> -    (start-process-shell-command command nil command)))
...
>> +    (make-process
>> +     :name "mailcap-view-file" :connection-type 'pipe :noquery t
>> +     :buffer nil ; "*Messages*" may be suitable for debugging
>> +     :sentinel (lambda (proc event)
>> +                 (when (and (memq (process-status proc) '(exit signal))
>> +                            (/= (process-exit-status proc) 0))
>> +                   (message
>> +                    "Command %s: %s."
>> +                    (mapconcat #'identity (process-command proc) " ")
>> +                    (substring event 0 -1))))
>> +     :command (list shell-file-name shell-command-switch command))))
> 
> First, you replace start-process-shell-command with make-process, and
> I'm not sure I understand why.  If all you want is to use pipes, why
> not simply bind process-connection-type around the call to
> start-process-shell-command?

>> +    ;; An alternative is `process-connection-type' let-bound to nil for
>> +    ;; `start-process-shell-command' call (with no chance to report failure).
-----------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

>> If main process of the handler fails then show a message with exit
>> reason.
---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> And with other handlers, this could be an
> incompatible behavior change if the handler behaves differently when
> its standard handles are connected to a pipe rather than a terminal
> device.

Example of such handler, please.




  parent reply	other threads:[~2021-07-02 12:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <F3C1A7E58B2441F7A674239043AC031A@us.oracle.com>
2021-06-01  6:56 ` bug#12972: 24.3.50; Move `org-open-file' and associated code out of Org mode Lars Ingebrigtsen
     [not found] ` <87r1hmdqek.fsf__16088.3597027109$1622530682$gmane$org@gnus.org>
2021-06-02 16:20   ` Maxim Nikulin
2021-07-01 17:01   ` bug#12972: [PATCH] Avoid regression in mailcap-view-file similar to Bug#44824 Maxim Nikulin
2021-07-01 18:38     ` Eli Zaretskii
     [not found]     ` <835yxtlw14.fsf__2546.8955327355$1625164803$gmane$org@gnu.org>
2021-07-02 12:21       ` Maxim Nikulin [this message]
2021-07-02 12:37         ` Eli Zaretskii
     [not found]         ` <837di8ki24.fsf__46278.4886871063$1625229533$gmane$org@gnu.org>
2021-07-02 16:24           ` Maxim Nikulin
2021-07-02 17:28             ` Eli Zaretskii
     [not found]             ` <831r8gk4m0.fsf__14172.0669272885$1625246977$gmane$org@gnu.org>
2021-07-03 11:29               ` Maxim Nikulin
2021-07-03 11:56                 ` Eli Zaretskii
     [not found]                 ` <83im1ripaz.fsf__31901.4239286602$1625313464$gmane$org@gnu.org>
2021-07-04 13:37                   ` Maxim Nikulin
2021-07-04 13:49                     ` Eli Zaretskii
2021-07-05 13:12                       ` Maxim Nikulin
2021-07-05 15:23                         ` Eli Zaretskii
2021-07-30 12:01     ` bug#12972: 24.3.50; Move `org-open-file' and associated code out of Org mode Lars Ingebrigtsen
2021-07-30 12:24       ` Maxim Nikulin
2021-07-30 12:42         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ddf1c46-0a28-4a2d-cc40-094ff74ee0ac@gmail.com \
    --to=manikulin@gmail.com \
    --cc=12972@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --subject='Re: bug#12972: [PATCH] Avoid regression in mailcap-view-file similar to Bug#44824' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).