From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aCogJaPUq2WtgwEAqHPOHw:P1 (envelope-from ) for ; Sat, 20 Jan 2024 15:11:47 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id aCogJaPUq2WtgwEAqHPOHw (envelope-from ) for ; Sat, 20 Jan 2024 15:11:47 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IMd97yA8; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705759907; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ALKju5OCMpTt4XwRr8R4gFeFzIdqDBA4ZjC2itZSv7w=; b=CoGUNmVrUpxoLli3SNI0gGYREwfECGVlNjPhE6hqA7HZ9Gy3q3QWimgD23pUgjwObDpFcn 3+T3MnaW5vPn5ZEPSwBQGllTw92100xqNnbDX033nbn2m8ZGXbW9Zf6RjJQvXXpU/NkPdw wk6EPuE7G3JfWwJsbtZSNvHuDobbHuAliUQbmdpyJR3k+Kk/RmJJQa0lnTCriYMzJIKAF0 Bqt8g18IMWWBeG2R/OfiB1QXZzb9MnK+P6VqPWre+GwtylWmo1CtBrD292Ihx5wzN5cqFE woPOj8ZJ26IhB23f88zLIyo6b4/lG6nYNBNFCjM9gEFZ80L1x+REpMI5OTsp1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IMd97yA8; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705759907; a=rsa-sha256; cv=none; b=Et7KBtZVgwB8M4z3VVgU5Y1UK13TWKhgsxTBWNBEKHtHJ/ujxt8ftrcF9qxdVvRGyEqMMO igw90mJqqeojbujyqnePt9Z9hmmytu+I6jVZkCu3/WS3gLhDKxCNP6gwSLzrWOw7WuJVIv yX2bAOJc7I5LQ2t9EMq8JTiw/woYPE4bCZ1m665qumVTq3x67gtlEIfmiK2Vad78/XKdyH PnUHwKaOIs/CYamIybqMiNVXipXbqBBz5LYXr8SzSvH5Xw4R96WS1//SxqONmd60OCOhR3 ApPdsp9UzhFgDuanWztBZAG9l/h4cGHXtBhfxPM9iwvKbhZJZV4tFeTO/3Hw4g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 869104222B for ; Sat, 20 Jan 2024 15:11:47 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRC3s-0004ip-Q1; Sat, 20 Jan 2024 09:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRC3r-0004ic-5D for emacs-orgmode@gnu.org; Sat, 20 Jan 2024 09:11:03 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRC3o-0004Wv-Ro for emacs-orgmode@gnu.org; Sat, 20 Jan 2024 09:11:02 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3C955240101 for ; Sat, 20 Jan 2024 15:10:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705759857; bh=9KtM9CneRIuyqQ364buoMFmlNckChkNz4ekJ5VwMxHA=; h=MIME-Version:Content-Type:Date:From:To:Cc:Subject:Message-ID: From; b=IMd97yA8p4EZwV+6sz55EI1B0W1KNfw8rH+54kXLyEU8rGguGoPYKH/FfD55wmmZZ 5OAmltfkevaE0eeY93ukgJVs3Bwi1JITQotTidLw53SmIjaN/yqcIdaQ2jXDzUSrLl UTk6+J4eJwItE7spjj74RDcBgBX7CtKmDWWOiNjLUVcV/oPZeixwCKxRrheHq/EXLs mi6PGKtGPGwBEOnod9d91h4dZmKbCr+1APv8wr4d1lgTIAwMtI8tPfz38EXXQoJQkF LvDuUoKCoZhMocNT5ty6y61WrJzL9a/gurujoWaqve92xuv4TuSIQe3xDHzuvXTJ3C 1yeuuYnJ874YA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4THJL85ZHMz9rxK; Sat, 20 Jan 2024 15:10:56 +0100 (CET) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_2cb068a6d9a9fa2ad6c6923a652bbc0d" Date: Sat, 20 Jan 2024 14:10:56 +0000 From: gerard.vermeulen@posteo.net To: Ihor Radchenko Cc: Emacs orgmode Subject: Re: [PATCH] Make command org-babel-detangle work interactively In-Reply-To: <874jf86vvu.fsf@localhost> References: <4e7b198382642ed3572e3fe42e6d1abc@posteo.net> <877ck573jh.fsf@localhost> <874jf86vvu.fsf@localhost> Message-ID: <1b0e6cc5b2aefe8269ce8791add80d5c@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=gerard.vermeulen@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -10.35 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -10.35 X-Migadu-Queue-Id: 869104222B X-TUID: lYAeNcQNsaUO --=_2cb068a6d9a9fa2ad6c6923a652bbc0d Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 20.01.2024 13:18, Ihor Radchenko wrote: > gerard.vermeulen@posteo.net writes: > >>> I suspect that you may have some misunderstanding about how >>> `org-babel-detangle' works. Its docstring says: >>> >>> Propagate changes in source file back original to Org file. >>> >>> So, it is expected to run from the tangled file; not from the Org >>> file. >> >> Yes, I misunderstood this and I see that my patch breaks this. >> >> I think there is a typo in the docstring: "original to" must become >> "to >> original" >> so that it ends with "back to original Org file". > > How about the attached patch? I have attached a modification of your patch. I think it is clearer with the risk of being too verbose, but the docstring width is < 80. --=_2cb068a6d9a9fa2ad6c6923a652bbc0d Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name=0001-lisp-ob-tangle.el-org-babel-detangle-Improve-docstri.patch Content-Disposition: attachment; filename=0001-lisp-ob-tangle.el-org-babel-detangle-Improve-docstri.patch; size=1085 RnJvbSAyYTFiODJkNmNiOTcwNDJlZGJkNGViYzZiYzA3MTU1ZjUwYWM4NTA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJaG9yIFJhZGNoZW5rbyA8eWFudGFyOTJAcG9zdGVvLm5ldD4K RGF0ZTogU2F0LCAyMCBKYW4gMjAyNCAxMzoxNzo0MyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGxp c3Avb2ItdGFuZ2xlLmVsIChvcmctYmFiZWwtZGV0YW5nbGUpOiBJbXByb3ZlIGRvY3N0cmluZwoK LS0tCiBsaXNwL29iLXRhbmdsZS5lbCB8IDYgKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb2ItdGFuZ2xlLmVs IGIvbGlzcC9vYi10YW5nbGUuZWwKaW5kZXggOTMzYTNlYmExLi5lZWExZmNhMmMgMTAwNjQ0Ci0t LSBhL2xpc3Avb2ItdGFuZ2xlLmVsCisrKyBiL2xpc3Avb2ItdGFuZ2xlLmVsCkBAIC02MTgsOSAr NjE4LDExIEBAIGJ5IGBvcmctYmFiZWwtZ2V0LXNyYy1ibG9jay1pbmZvJy4iCiAKIDs7IGRlLXRh bmdsaW5nIGZ1bmN0aW9ucwogKGRlZnVuIG9yZy1iYWJlbC1kZXRhbmdsZSAoJm9wdGlvbmFsIHNv dXJjZS1jb2RlLWZpbGUpCi0gICJQcm9wYWdhdGUgY2hhbmdlcyBpbiBzb3VyY2UgZmlsZSBiYWNr IG9yaWdpbmFsIHRvIE9yZyBmaWxlLgorICAiUHJvcGFnYXRlIGNoYW5nZXMgZnJvbSBjdXJyZW50 IHNvdXJjZSBidWZmZXIgYmFjayB0byB0aGUgb3JpZ2luYWwgT3JnIGZpbGUuCiBUaGlzIHJlcXVp cmVzIHRoYXQgY29kZSBibG9ja3Mgd2VyZSB0YW5nbGVkIHdpdGggbGluayBjb21tZW50cwotd2hp Y2ggZW5hYmxlIHRoZSBvcmlnaW5hbCBjb2RlIGJsb2NrcyB0byBiZSBmb3VuZC4iCit3aGljaCBl bmFibGUgdGhlIG9yaWdpbmFsIGNvZGUgYmxvY2tzIHRvIGJlIGZvdW5kLgorCitTT1VSQ0UtQ09E RS1GSUxFIGlzIGEgZmlsZSBwYXRoIHRoYXQgY2FuIGJlIHVzZWQgaW5zdGVhZCBvZiBjdXJyZW50 IGJ1ZmZlci4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgKHdoZW4g c291cmNlLWNvZGUtZmlsZSAoZmluZC1maWxlIHNvdXJjZS1jb2RlLWZpbGUpKQotLSAKMi40Mi4w Cgo= --=_2cb068a6d9a9fa2ad6c6923a652bbc0d--