From: tumashu <tumashu@163.com>
To: 我 <tumashu@163.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-capture: Add a custom to control save target file or not.
Date: Mon, 16 Apr 2018 09:06:12 +0800 (CST) [thread overview]
Message-ID: <1a449f88.16aa.162cbfce950.Coremail.tumashu@163.com> (raw)
In-Reply-To: <de3a784.4406.162c388d5ba.Coremail.tumashu@163.com>
[-- Attachment #1.1: Type: text/plain, Size: 668 bytes --]
At 2018-04-14 17:42:27, "tumashu" <tumashu@163.com> wrote:
>
>
>
>
>
>
>
>
>
>
>At 2018-04-14 15:44:00, "Nicolas Goaziou" <mail@nicolasgoaziou.fr> wrote:
>>Hello,
>>
>>tumashu <tumashu@163.com> writes:
>>
>>> I do not know why must save-buffer, may be for information safe :-)
>>
>>If there is no objection, I suggest to simply remove this call to
>>`save-buffer' instead of introducing a new variable.
>>
>
>Agree this idea, If user want to save-buffer when capture finish, they can
>add save-buffer to org-capture-after-finalize-hook or just type C-x C-s
>
>>Regards,
>>
>>--
>>Nicolas Goaziou 0x80A93738
[-- Attachment #1.2: Type: text/html, Size: 1003 bytes --]
[-- Attachment #2: 0001-org-capture-Do-not-save-buffer-when-run-org-capture-.patch --]
[-- Type: application/octet-stream, Size: 819 bytes --]
From 3e18b38f5e48f87addb386dec680cabc089f44d0 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Mon, 16 Apr 2018 09:02:13 +0800
Subject: [PATCH] org-capture: Do not save buffer when run
org-capture-finalize.
* lisp/org-capture.el (org-capture-finalize): Do not run save-buffer.
---
lisp/org-capture.el | 1 -
1 file changed, 1 deletion(-)
diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index f59e2ce6a..02f9e3df3 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -791,7 +791,6 @@ captured item after finalizing."
(org-encrypt-entry)))
;; Kill the indirect buffer
- (save-buffer)
(let ((return-wconf (org-capture-get :return-to-wconf 'local))
(new-buffer (org-capture-get :new-buffer 'local))
(kill-buffer (org-capture-get :kill-buffer 'local))
--
2.16.2
next prev parent reply other threads:[~2018-04-16 1:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 1:20 [PATCH] org-capture: Add a custom to control save target file or not tumashu
2018-04-12 13:22 ` Nicolas Goaziou
2018-04-13 2:10 ` tumashu
2018-04-14 7:44 ` Nicolas Goaziou
2018-04-14 9:42 ` tumashu
2018-04-16 1:06 ` tumashu [this message]
2018-04-16 10:11 ` Nicolas Goaziou
2018-09-26 17:11 ` Kaushal Modi
2018-09-26 17:29 ` Kaushal Modi
2018-09-26 18:11 ` Kaushal Modi
2018-09-27 5:47 ` Eric S Fraga
2018-09-27 13:33 ` Kaushal Modi
2018-09-28 12:28 ` Kaushal Modi
2018-09-28 20:50 ` Nicolas Goaziou
2018-09-28 21:17 ` Kaushal Modi
2018-09-29 6:31 ` Nicolas Goaziou
2018-09-29 10:27 ` Eric S Fraga
2018-09-29 10:35 ` Van L
2018-12-13 15:08 ` Kaushal Modi
2018-12-13 15:24 ` Kaushal Modi
2018-12-13 15:33 ` Kaushal Modi
2018-12-13 16:25 ` Nicolas Goaziou
2018-12-13 19:12 ` Kaushal Modi
2018-04-26 23:34 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a449f88.16aa.162cbfce950.Coremail.tumashu@163.com \
--to=tumashu@163.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).