From: Carsten Dominik <carsten.dominik@gmail.com>
To: Luke Amdor <luke.amdor@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-habit and headlines with links
Date: Thu, 28 Jan 2010 18:32:31 +0100 [thread overview]
Message-ID: <1E17282F-E612-4269-8BD3-46935B2B9E51@gmail.com> (raw)
In-Reply-To: <fb2eb6811001170745xac1240bi71311418655e4c7d@mail.gmail.com>
Hi Luke,
thanks for the bisect, that was useful.
Could you please try if the following patch does reliably fix this
problem?
Thanks!!
- Carsten
diff --git a/lisp/org-habit.el b/lisp/org-habit.el
index cf53057..deb8132 100644
--- a/lisp/org-habit.el
+++ b/lisp/org-habit.el
@@ -305,7 +305,7 @@ current time."
(defun org-habit-insert-consistency-graphs (&optional line)
"Insert consistency graph for any habitual tasks."
(let ((inhibit-read-only t) l c
- (buffer-invisibility-spec nil)
+ (buffer-invisibility-spec '(org-link))
(moment (time-subtract (current-time)
(list 0 (* 3600 org-extend-today-until) 0))))
(save-excursion
On Jan 17, 2010, at 4:45 PM, Luke Amdor wrote:
> When I have a headline with a link on it and I have that headline's
> habit property set to true, org-habit will barf all over my link
> when presenting the agenda. This will only happen when org-habit-
> graph-column is set something shorter than the full raw text of the
> link (which is about all of them).
>
> I ran git bisect on org-mode and found the bad commit to be:
>
> commit 2f5f6e401f187c2db8131cdbc4355b688ce4c55a
> Author: Carsten Dominik <carsten.dominik@gmail.com>
> Date: Mon Jan 4 09:58:53 2010 +0100
>
> Turn off invisibility while constructing habit graphs
>
> Bernt Hansen reported strange things happening to the display when
> graph tasks are hidden while updating a task in the agenda.
>
> Here's my bisect log:
>
> # bad: [0e370d498b34469a025cdce864fd5c5987bf8050] Fix typo
> # good: [a7fb89e9edf59f50294199046e570b4b11bb13b1] Merge branch
> 'master' of git+ssh://repo.or.cz/srv/git/org-mode
> git bisect start 'origin/master' 'HEAD'
> # good: [21ad7f0bef20addfe15fbe3e95d65e6c810d68f1] Fix typo
> git bisect good 21ad7f0bef20addfe15fbe3e95d65e6c810d68f1
> # good: [0b5d9bf1c62454523b275dd6a6b95bf881580eb1] Merge branch 'org-
> ctags'
> git bisect good 0b5d9bf1c62454523b275dd6a6b95bf881580eb1
> # bad: [588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9] org-exp-
> generic.el: Fix bug with closing bodies
> git bisect bad 588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9
> # bad: [32441cd15150f541d3ba50633cfb9fffc8d3d11a] Fix agenda link
> opening bug
> git bisect bad 32441cd15150f541d3ba50633cfb9fffc8d3d11a
> # bad: [ddcb2be1c8920fabfbca3777cc774ed1ac653a6e] Work-around for
> formatting bug with email subject line from wanderlust
> git bisect bad ddcb2be1c8920fabfbca3777cc774ed1ac653a6e
> # good: [c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710] Make C-c r C
> customize remember templates
> git bisect good c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710
> # good: [f266ee62bb8282cc883adea9f26362b2d3b1ab7d] Fix typo
> git bisect good f266ee62bb8282cc883adea9f26362b2d3b1ab7d
> # bad: [2f5f6e401f187c2db8131cdbc4355b688ce4c55a] Turn off
> invisibility while constructing habit graphs
> git bisect bad 2f5f6e401f187c2db8131cdbc4355b688ce4c55a
>
> Luke
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
next prev parent reply other threads:[~2010-01-28 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 15:45 Bug: org-habit and headlines with links Luke Amdor
2010-01-28 17:32 ` Carsten Dominik [this message]
2010-01-31 16:46 ` Luke Amdor
2010-01-31 16:54 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1E17282F-E612-4269-8BD3-46935B2B9E51@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=luke.amdor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).