From: Matt <matt@excalamus.com>
To: "Ihor Radchenko" <yantar92@posteo.net>
Cc: "osher jacob" <osherz5@gmail.com>,
"emacs-orgmode" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] ob-shell doesn't evaluate last line on Windows (cmd/cmdproxy) [9.6.1 ( @ c:/Users/Osher/AppData/Roaming/.emacs.d/elpa/org-9.6.1/)]
Date: Wed, 25 Jan 2023 23:04:08 -0500 [thread overview]
Message-ID: <185ec3f46e2.f96332c0506072.2994965640426706061@excalamus.com> (raw)
In-Reply-To: <185dc9cbce2.e7688b29675726.108231333271155983@excalamus.com>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
> ---- On Fri, 20 Jan 2023 04:27:18 -0500 Ihor Radchenko wrote ---
> I think `org-babel--shell-command-on-region' will be more appropriate.
> Because similar issues might appear when attempting to evaluate other
> code blocks on Windows, where `shell-file-name' is set to cmdproxy.exe.
Is something like this what you're thinking? Or, do we want to check explicitly for "cmdproxy.exe"?
Also, this bug isn't currently tracked in Woof!. I'm not able to confirm it, but since we're putting in a fix, should be add it anyway?
[-- Attachment #2: ob-eval-handle-windows-shell.patch --]
[-- Type: application/octet-stream, Size: 718 bytes --]
diff --git a/lisp/ob-eval.el b/lisp/ob-eval.el
index b9d1f7f23..9d79527a0 100644
--- a/lisp/ob-eval.el
+++ b/lisp/ob-eval.el
@@ -118,7 +118,13 @@ returned."
(if error-file
(list t error-file)
t)
- nil shell-command-switch command))
+ nil shell-command-switch
+ ;; Pass newline to satisfy Windows
+ ;; cmdproxy.exe prompt for More.
+ ;;
+ ;; See:
+ ;; `https://list.orgmode.org/orgmode/87bkmttv2h.fsf@localhost/'
+ (concat command "\n")))
(when (and input-file (file-exists-p input-file)
;; bind org-babel--debug-input around the call to keep
next prev parent reply other threads:[~2023-01-26 4:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 16:27 [BUG] ob-shell doesn't evaluate last line on Windows (cmd/cmdproxy) [9.6.1 ( @ c:/Users/Osher/AppData/Roaming/.emacs.d/elpa/org-9.6.1/)] Osher Jacob
2023-01-16 21:40 ` Matt
2023-01-17 1:07 ` Matt
2023-01-17 19:53 ` Osher Jacob
2023-01-18 5:09 ` Matt
2023-01-18 9:05 ` Ihor Radchenko
2023-01-19 16:28 ` Osher Jacob
2023-01-20 4:29 ` Matt
2023-01-20 9:27 ` Ihor Radchenko
2023-01-23 3:12 ` Matt
2023-01-23 11:42 ` Ihor Radchenko
2023-01-26 4:04 ` Matt [this message]
2023-01-26 9:51 ` Ihor Radchenko
2023-01-30 6:00 ` Matt
2023-01-30 14:00 ` Ihor Radchenko
2023-01-30 17:08 ` Matt
2023-02-01 12:05 ` Ihor Radchenko
2023-02-01 20:21 ` Matt
2023-01-20 9:24 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=185ec3f46e2.f96332c0506072.2994965640426706061@excalamus.com \
--to=matt@excalamus.com \
--cc=emacs-orgmode@gnu.org \
--cc=osherz5@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).