From: Matt <matt@excalamus.com>
To: "Max Nikulin" <manikulin@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-shell-test, test-ob-shell and introduction
Date: Wed, 05 Jan 2022 22:47:53 -0500 [thread overview]
Message-ID: <17e2d800e0e.cfffb732642942.2036522928042669584@excalamus.com> (raw)
In-Reply-To: <sr4ji5$dld$1@ciao.gmane.io>
> Thank you, I was not aware of ":cmdline" argument and of ":shebang" as a
> means to avoid stray prompts (I have seen mentions of similar problem
> for other languages in this list).
You're welcome! I was surprised to find those in the source. Glad to have documented them and even happier to hear that it's news to others.
> - https://www.mirbsd.org/pics/logo-grey.png works only with http:
> protocol for me.
I updated (downgraded?) it to http. I'm also seeing that the kornshell logo is intermittently broken. Not quite sure the best way to go about fixing that. Maybe commit copies? Use something like archive.org? Sounds like a problem for someone else (e.g. future me). I'm out of time for tonight.
> - I am unsure concerning example after "…or as a standlone script.",
> maybe it should be wrapped into #+begin_example.
Good call. That example was wonky. I've given a different one. Not sure it's better, though. I find the shebang behavior tricky to demo in a simple way.
> - In some cases "sh" is used despite bashisms in the code like "declare"
> or "echo -ne". Actually "printf" may be more convenient instead of "echo -n"
> - "export" in session example is unnecessary. It is matter of taste
> though. Bash and dash is not the case, but some shells require that
> assignment and export should be separate commands.
Good catch! Since arrays are only defined in ob-shell using bash, I've updated that example to use bash. Otherwise, I've removed the exports.
> - In your examples variable values are simple. Often it is safer to add
> double quotes around variable or command expansion. I would consider
> adding quotes just to encourage people to do the same by default with
> hope that less scripts will give strange results in response to a file
> name containing a space. Actually my first impression was that
> backslashes before quotes in some cases were added by mistake. Another
> unescaped pair of quotes may make your intention more clear. However it
> is related to code style where everybody has opinion, so I do not insist.
I appreciate these clarifications. Admittedly, I'm not great with shell scripting. Your recommendations appear sound to me and I've tried to incorporate them.
The updates have been made and are pushed. Thanks for your feedback!
next prev parent reply other threads:[~2022-01-06 3:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:37 [PATCH] ob-shell-test, test-ob-shell and introduction Matt
2021-11-22 18:43 ` Timothy
2021-11-24 18:48 ` Matt
2021-12-02 9:39 ` Timothy
2021-12-06 3:50 ` Matt
2021-12-06 4:50 ` Thomas S. Dye
2021-12-18 7:03 ` Matt
2021-12-18 20:51 ` Thomas S. Dye
2021-12-31 17:04 ` Thomas S. Dye
2021-12-31 19:18 ` Matt
2021-12-31 22:11 ` Thomas S. Dye
2022-01-02 4:32 ` Matt
2022-01-02 18:57 ` Thomas S. Dye
2022-01-05 17:12 ` Max Nikulin
2022-01-06 3:47 ` Matt [this message]
2022-01-07 16:18 ` Max Nikulin
2021-11-22 19:08 ` Thomas S. Dye
2021-11-23 4:42 ` [PATCH] ob-doc-shell.org (was [PATCH] ob-shell-test, test-ob-shell and introduction) Matt
2021-11-23 4:59 ` Thomas S. Dye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e2d800e0e.cfffb732642942.2036522928042669584@excalamus.com \
--to=matt@excalamus.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).