From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Kampas Subject: Re: Bug: Matching tags: results incomplete when mixing group tags and their ancestors [9.1.7 (9.1.7-12-g74f6ed-elpaplus @ /home/martin/.emacs.d/elpa/org-plus-contrib-20180305/)] Date: Thu, 15 Mar 2018 15:44:22 +0100 Message-ID: <1695362.3m693ds4Fp@5th> References: <16731993.gXpk8AjVC7@5th> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewU7K-0006el-G8 for emacs-orgmode@gnu.org; Thu, 15 Mar 2018 10:44:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewU7G-0006X6-J0 for emacs-orgmode@gnu.org; Thu, 15 Mar 2018 10:44:30 -0400 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:35827) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewU7G-0006WH-97 for emacs-orgmode@gnu.org; Thu, 15 Mar 2018 10:44:26 -0400 Received: by mail-wm0-x231.google.com with SMTP id x7so10955061wmc.0 for ; Thu, 15 Mar 2018 07:44:25 -0700 (PDT) Received: from 5th.localnet (ip-4-23.hlucinnet.cz. [93.91.243.23]) by smtp.gmail.com with ESMTPSA id a72sm3092210wme.28.2018.03.15.07.44.22 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 07:44:23 -0700 (PDT) In-Reply-To: <16731993.gXpk8AjVC7@5th> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi, This seems to fix the bug. Best Regards, Martin >From fef860e356a4ca75366f69ec9c2d52252c9d7d3f Mon Sep 17 00:00:00 2001 From: Martin Kampas Date: Thu, 15 Mar 2018 15:41:53 +0100 Subject: [PATCH] Fix matching tags when mixing group tags and their ancestors * lisp/org.el (org-expand-tags): Fix recursion stop condition See http://lists.gnu.org/r/emacs-orgmode/2018-03/msg00228.html --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 76bc60c88..7bf013390 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -13960,7 +13960,7 @@ When DOWNCASE is non-nil, expand downcased TAGS." (tag (match-string 2 return-match)) (tag (if downcased (downcase tag) tag))) (unless (or (get-text-property 0 'grouptag (match-string 2 return- match)) - (member tag work-already-expanded)) + (member tag tags-already-expanded)) (setq tags-in-group (assoc tag taggroups)) (push tag work-already-expanded) ;; Recursively expand each tag in the group, if the tag hasn't -- 2.16.2