From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YDtPELNUDGLvGwEAgWs5BA (envelope-from ) for ; Wed, 16 Feb 2022 02:34:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mAnnCLNUDGJ4OQAAG6o9tA (envelope-from ) for ; Wed, 16 Feb 2022 02:34:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA8423FEE9 for ; Wed, 16 Feb 2022 02:34:42 +0100 (CET) Received: from localhost ([::1]:55964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nK9DN-0007TG-Rp for larch@yhetil.org; Tue, 15 Feb 2022 20:34:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK98I-00069q-E9 for emacs-orgmode@gnu.org; Tue, 15 Feb 2022 20:29:26 -0500 Received: from mail.sift.net ([50.249.120.161]:65177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK98G-0003wV-MX for emacs-orgmode@gnu.org; Tue, 15 Feb 2022 20:29:26 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.sift.net (Postfix) with ESMTP id E549D815144E; Tue, 15 Feb 2022 19:29:22 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sift.net; h= content-type:content-type:mime-version:references:in-reply-to :message-id:x-mailer:date:date:subject:subject:from:from :received:received; s=sift-net; t=1644974962; x=1645838963; bh=c L4xT64h9EhqelkiPLMQR6FMEx0EoKMCrZ1s/Ykkryc=; b=jJC26aaxu4jl+w391 FUt0+/wbNCgfhAH2+eoNlt2DqD4QHGtDNntdqmmKueJ7lrG/nNwn2DspGt6z2sjF 5jyLBIDaudxV7SNYpJAj8C38w9uzrPgQy/eOnZG0A966ec9yowQD2Q6cOgQ/DH39 Aw7Q5RHINrWsn7+xgtnFk7uXCDLve1DFqSd5Ji0BIZiH79bkEJPVUfDUa8i6R6NA Sh9lxHV6O0wln/2RPyEQVjWEJdWysF47cQuBqFrJ+kvS2DUha87M3pAXH44+3Sgl m/IqwHVKFLBr98P2T5U6EOjRMMzTtjd3RKnrN+ssUOKoGRDDhjE5WgtmKiawcb4L dIiMA== X-Virus-Scanned: Debian amavisd-new at sift.net Received: from mail.sift.net ([127.0.0.1]) by localhost (mail.sift.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VFoERMGNG1e6; Tue, 15 Feb 2022 19:29:22 -0600 (CST) Received: from [192.168.86.30] (162-219-230-90.fttp.usinternet.com [162.219.230.90]) (Authenticated sender: rpg) by mail.sift.net (Postfix) with ESMTPSA id D1B378022480; Tue, 15 Feb 2022 19:29:21 -0600 (CST) From: "Robert Goldman" To: "Max Nikulin" Subject: Re: [PATCH v3] Fix FAQ entry about mailto links. Date: Tue, 15 Feb 2022 19:29:21 -0600 X-Mailer: MailMate (1.13.2r5673) Message-ID: <15C13708-4FD8-40AC-A86B-ACEEE9D8E109@sift.net> In-Reply-To: <9437ade2-af18-f97e-8790-a2df27c9017c@gmail.com> References: <11DC93C5-2600-4B6B-B7E0-B200AB274C35@sift.net> <9437ade2-af18-f97e-8790-a2df27c9017c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=50.249.120.161; envelope-from=rpgoldman@sift.net; helo=mail.sift.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644975282; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TrKqc30wF5+HRk+aEf6ocswVXY5uaRu4+DlX6EGhoA4=; b=FKFGT0fJkjOtnrs53RpsqGUn+Dw7/eVQw8bZpdEsMRsnJtC7sX0Pi/OX4G0eoGIjPeWDRd LqbRUGB+xWWqZboY4y3UF+7yYfOiVDv7RdophG1ZCDU/788f/tkrLP1MqNTUdoL0sJ0ZtF 2wSHEMXSptllYzYj1y2gZYe61grrPJeDSu9i4qnvDeLCwBSMxmepg3YtLtdVOa94lwpPz4 LzjJ3diFviw+D7hoifSQl0BWMrn1eoH8F9ZyzKJKTL59xb8ToDxu7xBrvSzokPtn4iRykb RYfcQASba9zx89lEQuckdwM6Hb68dqsbt/lXiilYs4E7+nozdYkn941aJenxww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644975282; a=rsa-sha256; cv=none; b=SJS24RGv3lCTUQPNL++hEDMnaypJUiqQvw7pzZZGG3Owk5zPcyYAitPk5aW2DW5nN/t4Bw HrB2N2kKHSGabkp7F/p3gd6EQ+O3U5N6nTmtAcnx1HwpbMFu8GAeywnkkoNqu3Mlua5cSy fV7q3YWWIlqXlco5PoJ/NEwO8VYO1Nk6XW+fQUw5drGC+C/9Ui9utno2X6/KeYfC8VZIqZ a6CouF5lLhWyKF8myz37HnTtc7jxsUMGXkjfj/AiA/k3hNJb2qdG7hLPcg5FQ8W9qOTMkK UZWo6sp5RiSr8L6Vfpi3IlfKdnDdsXtrQNnaKVK5tnV/DFBt/tmXJzuubElzgQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=sift.net header.s=sift-net header.b=jJC26aax; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.93 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=sift.net header.s=sift-net header.b=jJC26aax; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AA8423FEE9 X-Spam-Score: -8.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: iQqNt+DER7X5 On 14 Feb 2022, at 7:22, Max Nikulin wrote: > On 11/02/2022 00:42, Robert Goldman wrote: >> >> There are a couple of minor issues in the patch you sent (including a >> couple of grammatical errors), so attached is a revision. > > Great. Thank you, Robert, it exact reason why I asked for a review. > > I am sending the updated patch and a diff to your edits to highlight > my latest changes. Hello, Max -- Some responses below, then I think merging would be fine. I am losing my ability and energy to process these patch files, honestly. > >> From e7f0f2c51950b3c0f181191c5210ea26cafc03f4 Mon Sep 17 00:00:00 >> 2001 >> From: "Robert P. Goldman" >> Date: Thu, 10 Feb 2022 11:20:36 -0600 >> Subject: [PATCH 2/4] Revert "Fix FAQ entry about mailto links." >> >> This reverts commit b8158af7a839a751e6976cd95d18a5d5f199024a. > > Would you like to have you original version in git history? For me it > is not a problem to make my patch updating yours one without reverting > the original commit (create another branch, cherry-pick commits, > resolve conflict to the latest state). Otherwise you can avoid > unnecessary commits in your local repository by either applying my > patch to a new branch or using "git rebase -i master" to drop > unnecessary commits. I don't need to be credited; it would be fine to just merge in whatever way is convenient. > >> +If you prefer an external application that is /not/ the one >> configured >> +in your desktop environment, > > What is bothering me a bit is the entry title "Org-mode is not opening > mailto links in my *default* mail client". The updated variant mostly > discusses changing of defaults. The whole thing addresses how to open mailto links in the default mail client. It's not our fault that figuring out how org-mode dispatches these links and then what goes on inside browse-url is so complicated! >> +**side comment:** the above paragraph is hard to understand. Would >> it be >> +possible to add pointers to the discussion of these issues? > > I do not follow Emacs development. The source is git commit history > and commit messages rarely have links to discussion or references to > bug tracker. To be honest, I'm not sure what value this whole comment section has. Given that, I'm ok with whatever you want to do: leave it as it, try to fix it, or just remove it altogether. I actually think that removing it might be best. It's confusing, and will eventually become out-of-date, and who will update it? I'll leave it to you to choose. Best, R