From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tyler Smith <tyler@plantarum.ca>
Subject: Re: org-capture quitting and make-capture-frame
Date: Mon, 23 Oct 2017 16:41:47 -0400
Message-ID: <1508791307.1042871.1148450728.33D4D6F3@webmail.messagingengine.com>
References: <1508770777.115397.1148043056.71AE2BBC@webmail.messagingengine.com>
	<87wp3lr5ro.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53691)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tyler@plantarum.ca>) id 1e6jXk-0002TH-Vg
	for emacs-orgmode@gnu.org; Mon, 23 Oct 2017 16:41:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tyler@plantarum.ca>) id 1e6jXh-00062r-05
	for emacs-orgmode@gnu.org; Mon, 23 Oct 2017 16:41:53 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44635)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <tyler@plantarum.ca>) id 1e6jXg-00062I-IO
	for emacs-orgmode@gnu.org; Mon, 23 Oct 2017 16:41:48 -0400
In-Reply-To: <87wp3lr5ro.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Emacs Org-Mode Help <emacs-orgmode@gnu.org>

On Mon, Oct 23, 2017, at 04:03 PM, Nicolas Goaziou wrote:
> 
> Wouldn't it make more sense to turn it into 
> 
>  (message "Abort")
> 
> ? After all, it is not an error. It also allow to call other functions,
> e.g., `delete-frame' after exiting capture.
> 
> WDYT?
> 

I did think it was odd that this called an error, as it isn't an error
at all. 

I'm not sure how calling `(message ...)` at that point would enable
calling `delete-frame` after exiting capture? At the moment I'm calling
`delete` frame it by advising org-capture-destroy and
org-capture-finalize. I don't think either are called when you quit out
of the template selection dialog. Quitting needs to do something that
you can respond to, either with a hook, an advised function or something
else?

My proposal was just the first thing that I thought of, I'm sure there
are better solutions. That could be (message ...), but I'm missing
something in that case.

Best,

Tyler