From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Getzner Subject: Re: Multi-line links Date: Mon, 04 Aug 2014 13:03:54 +0200 Message-ID: <1407150234.2107.4.camel@gmx.de> References: <1404297563.12348.4.camel@glenalbyn> <1404308028.12348.7.camel@glenalbyn> <87egxz3q8m.fsf@nicolasgoaziou.fr> <1404663940.11764.1.camel@wirrsal> <87tx6uxp66.fsf@nicolasgoaziou.fr> <1406027525.16949.8.camel@gmx.de> <87oawcnt3s.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEG3h-0006zA-Ew for emacs-orgmode@gnu.org; Mon, 04 Aug 2014 07:04:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEG3Z-0001Ku-Vi for emacs-orgmode@gnu.org; Mon, 04 Aug 2014 07:04:05 -0400 Received: from mout.gmx.net ([212.227.15.19]:64859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEG3Z-0001KY-LQ for emacs-orgmode@gnu.org; Mon, 04 Aug 2014 07:03:57 -0400 In-Reply-To: <87oawcnt3s.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Hello Nicolas, On Sa, 2014-07-26 at 15:32 +0200, Nicolas Goaziou wrote: > In the long run, I'm pretty sure the project will benefit more if you > bring in your own, temporary, inexperience and start hacking from there. I=E2=80=99ll definitely look into this once I get a hang of Elisp. When I (unsuccessfully) tried to figure out how links are handled, it occurred to me some more inline docs would be useful; but then again maybe once one is used to Elisp the code becomes more transparent. When I have some time for another attempt to wrap my head around the code, maybe I could try adding in some comments as I go along. > > since multi-line descriptions seemed to be working (though only for < > > 3 lines) and since the raw-path seemed to contain the needed > > line-breaks already. But if I understand you correctly, the > > complication is that the path parsing is the same across different > > link types, and so one cannot simply fix it up so that :path is > > equivalent to :raw-path, just with the link prefix stripped of? >=20 > I fixed it in maint. "org-element.el" used an inadequate regexp to > analyze the path. Could you confirm it? If I understand correctly, this change addresses the issue of truncated =C2=ABpath=C2=BB and =C2=ABraw-link=C2=BB? These seem to return the expecte= d results for multi-line links now. Wonderful! Thank you very much for this! The syntax highlighting seems to also work, though it requires refreshing the buffer display. The only remaining issue would be that these links can only be triggered from the first line. Clicking on another line will yield =C2=ABNo link found=C2=BB, so I cannot get org-ref to return the BibTeX entry appropriate for the line from which the action is triggered. Strangely, when I inspect the other lines using org-element-context, the link type is correctly shown, even though it=E2=80=99s a few lines befo= re point. But when issuing org-open-at-point, it seems no handler is found when point is not on the first line of a multi-line link. Best regards, Tobias