From: Tobias Getzner <tobias.getzner@gmx.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Multi-line links
Date: Mon, 04 Aug 2014 13:03:54 +0200 [thread overview]
Message-ID: <1407150234.2107.4.camel@gmx.de> (raw)
In-Reply-To: <87oawcnt3s.fsf@nicolasgoaziou.fr>
Hello Nicolas,
On Sa, 2014-07-26 at 15:32 +0200, Nicolas Goaziou wrote:
> In the long run, I'm pretty sure the project will benefit more if you
> bring in your own, temporary, inexperience and start hacking from there.
I’ll definitely look into this once I get a hang of Elisp. When I
(unsuccessfully) tried to figure out how links are handled, it occurred
to me some more inline docs would be useful; but then again maybe once
one is used to Elisp the code becomes more transparent. When I have
some time for another attempt to wrap my head around the code, maybe
I could try adding in some comments as I go along.
> > since multi-line descriptions seemed to be working (though only for <
> > 3 lines) and since the raw-path seemed to contain the needed
> > line-breaks already. But if I understand you correctly, the
> > complication is that the path parsing is the same across different
> > link types, and so one cannot simply fix it up so that :path is
> > equivalent to :raw-path, just with the link prefix stripped of?
>
> I fixed it in maint. "org-element.el" used an inadequate regexp to
> analyze the path. Could you confirm it?
If I understand correctly, this change addresses the issue of truncated
«path» and «raw-link»? These seem to return the expected results for
multi-line links now. Wonderful! Thank you very much for this!
The syntax highlighting seems to also work, though it requires
refreshing the buffer display.
The only remaining issue would be that these links can only be
triggered from the first line. Clicking on another line will yield «No
link found», so I cannot get org-ref to return the BibTeX entry
appropriate for the line from which the action is triggered.
Strangely, when I inspect the other lines using org-element-context,
the link type is correctly shown, even though it’s a few lines before
point. But when issuing org-open-at-point, it seems no handler is found
when point is not on the first line of a multi-line link.
Best regards,
Tobias
next prev parent reply other threads:[~2014-08-04 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 10:39 Multi-line links Tobias Getzner
2014-07-02 13:33 ` Tobias Getzner
2014-07-06 7:23 ` Nicolas Goaziou
2014-07-06 16:25 ` Tobias Getzner
2014-07-06 19:28 ` Nicolas Goaziou
2014-07-22 11:12 ` Tobias Getzner
2014-07-26 13:32 ` Nicolas Goaziou
2014-08-04 11:03 ` Tobias Getzner [this message]
2014-08-06 11:36 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407150234.2107.4.camel@gmx.de \
--to=tobias.getzner@gmx.de \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).