From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert Krewinkel Subject: Re: [PATCH] org.el (org-offer-links-in-entry): Remove code duplication Date: Sun, 11 May 2014 18:33:28 +0200 Message-ID: <1399826009-369-1-git-send-email-tarleb@moltkeplatz.de> References: <87k39zmcw2.fsf@bzg.ath.cx> Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjWii-00076W-PT for emacs-orgmode@gnu.org; Sun, 11 May 2014 12:35:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjWid-0003FU-FK for emacs-orgmode@gnu.org; Sun, 11 May 2014 12:35:24 -0400 In-Reply-To: <87k39zmcw2.fsf@bzg.ath.cx> In-Reply-To: <87k39zmcw2.fsf@bzg.ath.cx> References: <87k39zmcw2.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Albert Krewinkel , emacs-orgmode@gnu.org Hi Bastien, Bastien writes: > Albert Krewinkel writes: > >> * org.el (org-offer-links-in-entry): Use `org-any-link-re' to avoid >> code duplication. > > This is not really code duplication, as the output of `org-any-link-re' > is different from the output of the current sexp in the code. I'm not exactly sure what you mean, are you referring to the variables' different representation in the source? I double checked that (string-equal re org-any-link-re) => t when `re' is set to the old value (as of commit 7c8559e). > That said, the change looks good anyway. Can you double-check there > cannot be any problem with the value of `org-any-link-re'? The variable is only ever changed when calling `org-make-link-regexps', so I'm quite positive that the change does not have any unintended side effects. The test suite passes, too. >> This is a TINYCHANGE. > > (TINYCHANGE should stand alone on the line.) Done. As an aside: I did sign the copyright assignment papers to be able to contrivute to Gnus, but that probably wouldn't help much, as Org is a different project. Is that correct? > Thanks! No, thank you all for all the work you put into this! It is truly amazing! Albert Krewinkel (1): org.el (org-offer-links-in-entry): Reuse global variable lisp/org.el | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.0.0.rc0