* [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]
2014-03-28 23:02 wgg2
@ 2014-04-05 18:28 ` Sacha Chua
2014-04-07 13:52 ` W. Greenhouse
2014-04-11 9:29 ` Bastien
0 siblings, 2 replies; 4+ messages in thread
From: Sacha Chua @ 2014-04-05 18:28 UTC (permalink / raw)
To: emacs-orgmode
wgg2@member.fsf.org writes:
> On the latest `org-plus-contrib' build from the org package.el repo, my
> Agenda buffers (for any Agenda command) fail to render properly, with
> these pertinent lines from *Backtrace*:
> Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
> put-text-property(28484 nil org-appt-warntime "60")
...
> I then isolated this to the following lines of function
> `org-agenda-prepare-buffers':
> (or (memq 'appt org-agenda-ignore-drawer-properties)
> (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime))
I ran into a similar problem with org-agenda-prepare-buffers and the
EFFORT property. This change to org-refresh-properties seems to fix it:
diff --git a/lisp/org.el b/lisp/org.el
index f8615a2..bd9c05e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9393,7 +9393,7 @@ property to set."
(save-excursion
(org-back-to-heading t)
(put-text-property
- (point-at-bol) (outline-next-heading) tprop p))))))))
+ (point-at-bol) (or (outline-next-heading) (point-max)) tprop p))))))))
;;;; Link Stuff
The previous version by Bastien used (org-end-of-subtree t t), which had
checked for (eobp) in it, but outline-next-heading returns nil if there
are no further headings.
Sacha Chua
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]
2014-04-05 18:28 ` [PATCH] " Sacha Chua
@ 2014-04-07 13:52 ` W. Greenhouse
2014-04-11 9:29 ` Bastien
1 sibling, 0 replies; 4+ messages in thread
From: W. Greenhouse @ 2014-04-07 13:52 UTC (permalink / raw)
To: emacs-orgmode-mXXj517/zsQ
Sacha Chua <sacha-bc55NVWLdWuB+jHODAdFcQ@public.gmane.org> writes:
>
> I ran into a similar problem with org-agenda-prepare-buffers and the
> EFFORT property. This change to org-refresh-properties seems to fix it:
Awesome, thanks. :)
This patch is still needed (and works) as of the ELPA build from org
8.2.5h, commit g0820d0.
--
Best,
WGG
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]
@ 2014-04-07 18:16 Jonathan Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Johnson @ 2014-04-07 18:16 UTC (permalink / raw)
To: emacs-orgmode; +Cc: wgreenhouse
Org Mode community (and WGG),
Looks like my last email to this list was a duplicate. When I checked
on my post I saw that my GMANE search had hidden the recent post by
Sacha Chua, sorting by relevance rather than by newest-first.
Feel free to disregard/discard my duplicate.
Regards,
Jonathan
--
Jonathan Johnson <Jonathan.Johnson@Symphero.mn.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)]
2014-04-05 18:28 ` [PATCH] " Sacha Chua
2014-04-07 13:52 ` W. Greenhouse
@ 2014-04-11 9:29 ` Bastien
1 sibling, 0 replies; 4+ messages in thread
From: Bastien @ 2014-04-11 9:29 UTC (permalink / raw)
To: Sacha Chua; +Cc: emacs-orgmode
Hi Sacha,
Sacha Chua <sacha@sachachua.com> writes:
> I ran into a similar problem with org-agenda-prepare-buffers and the
> EFFORT property. This change to org-refresh-properties seems to fix
> it:
Applied in maint, thanks a lot!
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-11 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-07 18:16 [PATCH] Re: Bug: `org-agenda-prepare-buffers' fails at (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime) [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @ /home/wgg/.emacs.d/elpa/org-plus-contrib-20140324/)] Jonathan Johnson
-- strict thread matches above, loose matches on Subject: below --
2014-03-28 23:02 wgg2
2014-04-05 18:28 ` [PATCH] " Sacha Chua
2014-04-07 13:52 ` W. Greenhouse
2014-04-11 9:29 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).