emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Miguel Ruiz <rbenit68@yahoo.es>
To: Bastien <bzg@gnu.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: org-babel-gnuplot-quote-tsv-field does not work	properly (quotes); org-plot-quote-tsv-field does though
Date: Sun, 5 Jan 2014 12:27:16 +0000 (GMT)	[thread overview]
Message-ID: <1388924836.16031.YahooMailNeo@web171306.mail.ir2.yahoo.com> (raw)
In-Reply-To: <878uuuve93.fsf@bzg.ath.cx>


[-- Attachment #1.1: Type: text/plain, Size: 720 bytes --]

Thank you, Bastien. I'd prefer some of you writes the changelog entry; the patch is attached.





El Domingo 5 de enero de 2014 12:51, Bastien <bzg@gnu.org> escribió:
 
Hi Miguel,

Miguel Ruiz <rbenit68@yahoo.es> writes:

> Is it *this* enough:
>
> diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
> index cc9186b..426077b 100644
> --- a/lisp/ob-gnuplot.el
> +++ b/lisp/ob-gnuplot.el

Thanks for the fix -- could you format it with git format-patch
and add a proper ChangeLog?

See http://orgmode.org/worg/org-contribute.html#sec-4-2 for
details on how to submit a patch.  Please add TINYCHANGE at
the end of your commit message if you didn't sign the FSF
papers.

Thanks!

-- 
Bastien

[-- Attachment #1.2: Type: text/html, Size: 1940 bytes --]

[-- Attachment #2: 0001-Fix-typo-that-stopped-necessary-quoted-strings-in-gn.patch --]
[-- Type: application/octet-stream, Size: 847 bytes --]

From 1d00a79dbc473e35abc60aeaca8e0cfa7b59fdf0 Mon Sep 17 00:00:00 2001
From: "U-usuario-PC\\usuario" <rbenit68@yahoo.es>
Date: Sun, 5 Jan 2014 13:18:16 +0100
Subject: [PATCH] Fix typo that stopped necessary quoted strings in gnuplot
 temp data file from tables

---
 lisp/ob-gnuplot.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
index cc9186b..426077b 100644
--- a/lisp/ob-gnuplot.el
+++ b/lisp/ob-gnuplot.el
@@ -253,7 +253,7 @@ then create one.  Return the initialized session.  The current
 	(org-babel-gnuplot-quote-timestamp-field s)
       (if (zerop (length s))
 	  (or *org-babel-gnuplot-missing* s)
-	(if (string-match "[ \"]" "?")
+	(if (string-match "[ \"]" s)
 	    (concat "\"" (mapconcat 'identity (split-string s "\"") "\"\"")
 		    "\"")
 	  s)))))
-- 
1.7.9

next prev parent reply	other threads:[~2014-01-05 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-05  8:50 org-babel-gnuplot-quote-tsv-field does not work properly (quotes); org-plot-quote-tsv-field does though Miguel Ruiz
2014-01-05 11:46 ` Miguel Ruiz
2014-01-05 11:50   ` Bastien
2014-01-05 12:27     ` Miguel Ruiz [this message]
2014-01-05 13:15       ` Bastien

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:cc9186b dfblob:426077b
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388924836.16031.YahooMailNeo@web171306.mail.ir2.yahoo.com \
    --to=rbenit68@yahoo.es \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).